Smooth progress icmp #389
Merged
Smooth progress icmp #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only add unique alive hosts which are also present in the target list. We use short circuit evaluation to not add hosts in the alive hosts hash table which are not also in the list of target hosts. This way we make sure to only have the alive hosts which we are looking for in our hash table of alive host.
Also add documentation.
ArnoStiefvater
force-pushed
the
smooth-progress-icmp
branch
from
3d86b03
to
3410f02
Compare
It could happen that during the last batch the limit is reached. If the max_scan_hosts limit got reached we can not send the true number of dead hosts to ospd-openvas. We need to include the alive hosts which are above the limit as dead hosts for the progress bar. E.g. curr_alive=110 prev_alive=90 max_scan_hosts=100 batch=100. Normally we would send 80 as dead in this batch (20 new alive hosts) but because of the restriction we send 90 as dead. The 10 hosts which are over the limit are considered as dead.
jjnicola
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Continuously send new dead hosts to ospd-openvas to gradually update the progress bar for the case that only ICMP was chosen as alive test.
Why:
To get a better user experience when looking at the progress bar for the most common case of ICMP ping.
How:
Tested with scans via gvm-cli and looked if the count of dead hosts which are send to ospd-openvas are correct.
Checklist: