Add libldap2-dev to prerequisites #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libldap2 is a prerequisite library, but it's not listed in the apt-get section. Also reindented command to list one library per line, for clarity.
mattmundell
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libldap2is a prerequisite library, but it's not listed in theapt-getsection. This causes the library to compile without LDAP support.I also reindented the
apt-getcommand to list one library per line, for clarity. This makes explicit that there is not a 1-to-1 correspondence between the prerequisites and theapt-getcommand. For instance,libgiois not explicitly included. Since addinglibldap2-devfixed my issues I haven't investigated that further, but an expert might want to take a closer look.