Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert fix filtering error on first render for create display #4208

Conversation

daniele-mng
Copy link
Contributor

@daniele-mng daniele-mng commented Nov 20, 2024

What

Revert fix filtering error on first render for create display

Why

  • Different loading issue, on first render it blocks in loading state

References

GEA-714
#4200

Checklist

  • Tests

@daniele-mng daniele-mng requested review from a team as code owners November 20, 2024 10:14
@daniele-mng daniele-mng changed the base branch from main to opensight-ui November 20, 2024 10:14
Copy link

github-actions bot commented Nov 20, 2024

Conventional Commits Report

Type Number
Removed 1

🚀 Conventional commits found.

@daniele-mng daniele-mng force-pushed the Revert-fix-filtering-error-on-first-render-for-create-display- branch from 0c6de36 to 55f9180 Compare November 20, 2024 10:17
Copy link

github-actions bot commented Nov 20, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 135ae3e.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@daniele-mng daniele-mng force-pushed the Revert-fix-filtering-error-on-first-render-for-create-display- branch from 55f9180 to 135ae3e Compare November 20, 2024 10:18
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.68%. Comparing base (72f6060) to head (135ae3e).
Report is 2 commits behind head on opensight-ui.

Additional details and impacted files
@@               Coverage Diff                @@
##           opensight-ui    #4208      +/-   ##
================================================
- Coverage         62.69%   62.68%   -0.01%     
================================================
  Files              1111     1111              
  Lines             98812    98795      -17     
  Branches           6500     6497       -3     
================================================
- Hits              61948    61931      -17     
  Misses            36733    36733              
  Partials            131      131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@daniele-mng daniele-mng merged commit 3bea2a8 into opensight-ui Nov 20, 2024
10 checks passed
@daniele-mng daniele-mng deleted the Revert-fix-filtering-error-on-first-render-for-create-display- branch November 20, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants