Add feedback notification for feed sync #4120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
daniele-mng
force-pushed
the
add-feedback-for-feed-sync
branch
from
ae7a038 to
4dbcb9e
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Manifest Files |
daniele-mng
force-pushed
the
add-feedback-for-feed-sync
branch
from
4dbcb9e to
d976e6a
Compare
|
Looks good to me. I cannot judge the German translations so maybe someone else can take a look on that. |
a-h-abdelsalam
approved these changes
Sep 3, 2024
4D617274696E
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
These changes are necessary because if the feed is syncing, the scanner tasks would not run, and users would not be informed about it. By providing clear notifications and disabling the relevant buttons, users are better informed about the current state of the system and can avoid attempting actions that would not succeed.
References
GEA-417
Checklist