Add: Added a dedicated view for compliance audit reports #3952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3952 +/- ##
==========================================
+ Coverage 72.65% 72.85% +0.20%
==========================================
Files 1062 1078 +16
Lines 120912 125058 +4146
Branches 5990 6206 +216
==========================================
+ Hits 87843 91114 +3271
- Misses 33040 33913 +873
- Partials 29 31 +2 ☔ View full report in Codecov by Sentry. |
a-h-abdelsalam
force-pushed
the
add-dedicated-view-for-compliance-reports
branch
from
dcd49bf
to
0fa51d0
Compare
a-h-abdelsalam
force-pushed
the
add-dedicated-view-for-compliance-reports
branch
from
eb4a4af
to
b717560
Compare
a-h-abdelsalam
force-pushed
the
add-dedicated-view-for-compliance-reports
branch
from
f2a6c69
to
811e5a9
Compare
bjoernricks
reviewed
Feb 26, 2024
There was a problem hiding this comment.
First of all this PR looks good. My comments are mostly only style and convention related.
Some rules that should be considered:
- In JS we agreed on camelCase usage for functions, classes, variables and properties finally. Because I have a Python background and wrote most of the initial code we still have a lot of snake_case naming which we never get rid of. All new additions should use camelCase when possible. Personally I am not sure if this fits here with the report still using snake_case and the strong coupling between the audit, tasks, scan configs, policies and the two different reports.
- We agreed on using absolute imports without the
.jssuffix some while ago. This might not be consistent on all places. - New react components should be function components if possible. React class components are still supported and will be supported a long time but are considered legacy. And because you can't use hooks inside class components it is better to write only function components for new code.
|
Thank you for your review @bjoernricks. I applied the review suggestions where possible and also rewrote |
a-h-abdelsalam
force-pushed
the
add-dedicated-view-for-compliance-reports
branch
from
83a22c9
to
8a16fa8
Compare
bjoernricks
reviewed
Mar 12, 2024
a-h-abdelsalam
force-pushed
the
add-dedicated-view-for-compliance-reports
branch
from
a4a9c06
to
b474908
Compare
a-h-abdelsalam
force-pushed
the
add-dedicated-view-for-compliance-reports
branch
from
b474908
to
349acd0
Compare
a-h-abdelsalam
force-pushed
the
add-dedicated-view-for-compliance-reports
branch
from
c039b3e
to
ae14f69
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Manifest Files |
a-h-abdelsalam
force-pushed
the
add-dedicated-view-for-compliance-reports
branch
2 times, most recently
from
520fa21
to
32096cc
Compare
a-h-abdelsalam
force-pushed
the
add-dedicated-view-for-compliance-reports
branch
from
32096cc
to
c83f4ae
Compare
bjoernricks
reviewed
Jun 12, 2024
daniele-mng
reviewed
Jun 12, 2024
daniele-mng
reviewed
Jun 12, 2024
daniele-mng
reviewed
Jun 12, 2024
daniele-mng
reviewed
Jun 13, 2024
- Rewrite auditdeltadetailspage, auditdetailspage, auditreportlistpage, compliancelevelsgroup into functional components. - Use camel case instead of snake case - Use absolute imports without .js suffix
Rename *.js to *.jsx and make sure tests are running again.
Report links should switch to report or compliance report details page based on the feature toggle.
a-h-abdelsalam
force-pushed
the
add-dedicated-view-for-compliance-reports
branch
from
f0f0047
to
9ce7ec5
Compare
daniele-mng
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Currently GSA doesn't distinguish between different types of reports (vulnerability, compliance audit, etc.). Therefore there is no dedicated view yet, causing all filters to be accessible in different reports.
References
GEA-397, GEA-613
requires greenbone/gvmd#2125
requires greenbone/gsad#164