Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Introduce new function to remove leading zero fron version for correct links to GSM-Manual #3460

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Fix: Introduce new function to remove leading zero fron version for correct links to GSM-Manual #3460

merged 1 commit into from
Jun 9, 2022

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Jun 8, 2022 •
edited
Loading

What:

Why:

Fix #3459

How:

Checklist:

  • Tests
  • PR merge commit message adjusted
  • Labels for ports to other branches

@y0urself y0urself requested a review from a team as a code owner June 8, 2022 09:12
@y0urself y0urself added port-to-stable Use mergifiy to port PR to stable port-to-oldstable Use mergify to port PR to oldstable labels Jun 8, 2022
@y0urself y0urself enabled auto-merge (squash) June 8, 2022 09:13
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #3460 (ca25599) into main (d3cf6ff) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3460   +/-   ##
=======================================
  Coverage   59.12%   59.12%           
=======================================
  Files        1046     1046           
  Lines       25487    25491    +4     
  Branches     7450     7450           
=======================================
+ Hits        15068    15072    +4     
  Misses       9459     9459           
  Partials      960      960
Impacted Files Coverage Δ
src/gmp/gmpsettings.js 95.78% <100.00%> (ø)
src/version.js 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

bjoernricks
bjoernricks approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The leading zero just created headaches and a lot of issues. We shouldn't have added it at all.

@y0urself y0urself merged commit 7cb61dc into main Jun 9, 2022
@y0urself y0urself deleted the y0urself/fix-gsm-manual-links branch June 9, 2022 10:42
mergify bot pushed a commit that referenced this pull request Jun 9, 2022
@y0urself @mergify
Fix: Introduce new function to remove leading zero fron version for c…
1dc7919 
…orrect links to GSM-Manual (#3460)

(cherry picked from commit 7cb61dc)

# Conflicts:
#	src/version.js
@mergify mergify bot mentioned this pull request Jun 9, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jun 9, 2022
@y0urself @mergify
Fix: Introduce new function to remove leading zero fron version for c…
ea30e7f 
…orrect links to GSM-Manual (#3460)

(cherry picked from commit 7cb61dc)

# Conflicts:
#	src/gmp/gmpsettings.js
#	src/version.js
@mergify mergify bot mentioned this pull request Jun 9, 2022
Merged
@y0urself
Copy link
Member Author

y0urself commented Jun 9, 2022

The leading zero just created headaches and a lot of issues. We shouldn't have added it at all.

True. :/

y0urself added a commit that referenced this pull request Jun 9, 2022
@mergify @y0urself
Fix: Introduce new function to remove leading zero fron version for c…
3e87f07 
…orrect links to GSM-Manual (backport #3460) (#3461)

* Fix: Introduce new function to remove leading zero fron version for correct links to GSM-Manual (#3460)

(cherry picked from commit 7cb61dc)

# Conflicts:
#	src/version.js

* Fix conflict

Co-authored-by: Jaspar S <[email protected]>
bjoernricks added a commit that referenced this pull request Jun 9, 2022
@bjoernricks
Merge pull request #3462 from greenbone/mergify/bp/oldstable/pr-3460
5f76d32 
Fix: Introduce new function to remove leading zero fron version for correct links to GSM-Manual (backport #3460)
This was referenced Jul 8, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

@sarahd93 sarahd93 Awaiting requested review from sarahd93

@swaterkamp swaterkamp Awaiting requested review from swaterkamp

Assignees
No one assigned
Labels
port-to-oldstable Use mergify to port PR to oldstable port-to-stable Use mergifiy to port PR to stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Help Links do not work anymore.
2 participants
@y0urself @bjoernricks