Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable clone icon for superadmin users on listpages and detailspages #2634

Merged
merged 4 commits into from
Dec 15, 2020

Conversation

swaterkamp
Copy link
Member

What:
Disable the clone icon for superadmin users.

Why:
Superadmins can't be cloned, it doesn't make sense to offer the option just to throw an error.

How:

Checklist:

@swaterkamp swaterkamp self-assigned this Dec 15, 2020
@swaterkamp swaterkamp requested a review from a team December 15, 2020 18:37
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #2634 (5af7773) into gsa-20.08 (2f34292) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-20.08    #2634   +/-   ##
==========================================
  Coverage      53.06%   53.07%           
==========================================
  Files           1072     1072           
  Lines          25900    25904    +4     
  Branches        7372     7372           
==========================================
+ Hits           13744    13748    +4     
  Misses         11034    11034           
  Partials        1122     1122           
Impacted Files Coverage Δ
gsa/src/web/pages/users/detailspage.js 33.33% <ø> (ø)
gsa/src/web/pages/users/row.js 26.66% <ø> (ø)
gsa/src/gmp/models/user.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be0ffc9...5af7773. Read the comment docs.

@saberlynx saberlynx merged commit d835530 into greenbone:gsa-20.08 Dec 15, 2020
@swaterkamp swaterkamp deleted the DisableSuperadminCLone branch April 20, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants