Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codespaces merge into main #993

Merged
merged 100 commits into from
Nov 23, 2024
Merged

Codespaces merge into main #993

merged 100 commits into from
Nov 23, 2024

Conversation

ArneTR
Copy link
Member

@ArneTR ArneTR commented Nov 22, 2024

No description provided.

ArneTR and others added 30 commits November 7, 2023 11:59
@ArneTR
Create devcontainer.json
e4cc128
@ArneTR
Adding feature for installing GMT directly
45d279d
@ArneTR
Update devcontainer.json
28fecdb
@dan-mm
Update devcontainer.json - ubuntu 22.04
f2feffc
@dan-mm
Update devcontainer.json - just ubuntu
ed38e35
@dan-mm
cgroup providers will now check cgroupv1 paths if cgroupv2 paths are …
54537d1 
…not found
@dan-mm
codespaces on ubuntu 22.04; gmt install on codespace container creati…
b3bd7ab 
…on; splash screeen; readme link;
@dan-mm
try install on post-create command to see if it helps with second run…
d238a2b 
… issue (etc/hosts gets deleted)
@dan-mm
rewrite to etc/hosts on start
4dc538f
@dan-mm
add api_url to on-start script
a35e1a2
@dan-mm
add api_url to on-start script - wrong var name
97e1a1d
@dan-mm
print_message -> echo
3e3644f
@dan-mm
make port changes for codespaces setup script
a783de9
@dan-mm
set server_names_hash_bucket_size in nginx.conf
2437126
@dan-mm
fix spacing in port setup
6e45143
@dan-mm
fix port name for metrics, removed accidental paste
20fba98
@dan-mm
added -t flag to codespace install script run
16f3103
@dan-mm
add examples directory to codespace
e69d5a7
@dan-mm
update codespace splash - note on port visibility
f920a60
@dan-mm
add splash open to on-start script
f8ad1ca
@dan-mm
disable network io cgroup provider for codespace
00f21d3
@dan-mm
install reqs into codespace
8521fca
@dan-mm
remove code splash screen line from codespace on-start
92ecc24
@dan-mm
add common category to disabled providers in codespace
d286c14
@dan-mm
splash example is set to examples directory stress, not test stress
fab0237
@dan-mm
try starting splash screen with postStartCommand
515bbd2
@dan-mm
remove splash start from postStartCommand - it couldn't find the righ…
2d3a1fb 
…t code application to open
@dan-mm
added containerized/base split; added workflow to build github codesp…
c46bc2e 
…ace container; added devcontainer config for containerized version
@dan-mm
fix reference in contianerized devcontainer; removed duplicate docker…
5f1501e 
… install
@dan-mm
use secrets.github_token
0e0a8d2
ArneTR and others added 22 commits June 3, 2024 20:20
@ArneTR
Removed the no sleep to show container idle power
28cd1fb
@ArneTR
Showing energy for every runtime phase
da82f39
@ArneTR
Merge branch 'main' into codespaces
0ba104b 
* main: (32 commits)
  Updated Cloud Energy
  Bump orjson from 3.10.5 to 3.10.6 (#830)
  Added exact uri mode
  Bump pydantic from 2.7.4 to 2.8.0 (#829)
  Bump pylint from 3.2.3 to 3.2.5 (#828)
  Bump psycopg[binary] from 3.1.19 to 3.2.1 (#827)
  Bump redis from 5.0.6 to 5.0.7 (#822)
  Added machine name
  Calling fixture (#826)
  Co2eq totals and Co2i totals (#823)
  Wrong YML. Reducing guard clauses to minimum necessary
  check-date check added for skipped workflows
  Bump scipy from 1.13.1 to 1.14.0 (#820)
  Updated cloud energy
  Kaniko enable multi-stage builds (#819)
  Global timeout (#814)
  Local images support (#813)
  Warmup for machines added if too cool (#817)
  Added machine
  Added randomly (#818)
  ...
@ArneTR
Updated Cloud Energy
770294d
@ArneTR
Idle duration set to 10 to make container energy estimations more rel…
a4c6cfa 
…iable
@ArneTR
Clarification on Turbo Boost and when it is off
98fb794
@davidkopp @ArneTR
Improve Codespaces Setup (#833)
9128f28 
* Fix repo path in example

* minor

* Add VS Code extensions

* Add hint to make api port public to avoid CORS issues

* Remove YAML VS Code extension

* Open markdown files in preview mode by default

* Ignore backuped Makefile in Git

* Ensure ports are set to public after Codespace restart

* Update git repository URL

* Improve quickstart and add troubleshooting information

---------

Co-authored-by: Arne Tarara <[email protected]>
@ArneTR
Merge branch 'main' into codespaces
5ffc3d4 
* main: (210 commits)
  Clarification on Turbo Boost and when it is off
  Monotonic and low value check (#973)
  Phase Stats are now also saved if runs fails (#972)
  RAPL energy filtering moved to provider (#979)
  fixes the GCC warnings (#985)
  Bump psycopg-pool from 3.2.3 to 3.2.4 (#982)
  Bump aiohttp from 3.11.2 to 3.11.4 (#984)
  Fixed SCI link
  Hinting UTC
  Removed duplicate tests and fixed tests
  Bump aiohttp from 3.11.0 to 3.11.2 (#981)
  Added unit test for rescale energy value
  Bump aiohttp from 3.10.10 to 3.11.0 (#980)
  (fix): Repo submission to software/add was failing on non-main branch
  Added temporary rescale guard clause
  (fix): energy unit was falsely omitted in badge
  Bump fastapi[standard] from 0.115.4 to 0.115.5 (#978)
  Made cluster accuracy warning more verbose
  Removing duplicate value check in cluster
  Bump tqdm from 4.66.6 to 4.67.0 (#975)
  ...
@ArneTR
Disabling SSL for codespaces
c32bef8
@ArneTR
Loading block.conf also in Codespaces
da4cace
@ArneTR
Updated XGBoost
b2e0ceb
@ArneTR
Typos in the container providers+
6b9bb21
@ArneTR
Activating ports correctly + enabling XGboost manually
4155427
@ArneTR
Skipping lmsensors
27f404e
@ArneTR
Refactored get cgroup path to C lib
96eebb9
@ArneTR
Compile errors and makefile additions
916dfd7
@ArneTR
Makefile additions
d0d301a
@ArneTR
Removing unused vars
faad49e
@ArneTR
Using new --dev-cache-build switch. Was renamed
0cda379
@ArneTR
Defautl host blocking must be disabled in GH Codespaces
58c3c9f
@ArneTR
Check for memory file must be different
ee7d5c5
@ArneTR
Making codespaces work on main
41ea06e
@ArneTR
Copy link
Member Author

ArneTR commented Nov 23, 2024

@davidkopp I have merged the codespaces branch, refactored the CGroup reporters and made all changes explicit in the codespaces setup file.

After this merge it should now be possible to just open a codespace on main without any special setting or selecting the "Workshop" template.

If you are still using it feel free to give it a try if it works for you. Feedback would be greatly appreciated!

@ArneTR ArneTR merged commit 6172f32 into main Nov 23, 2024
0 of 3 checks passed
@ArneTR ArneTR deleted the codespaces branch November 23, 2024 13:51
ArneTR added a commit that referenced this pull request Nov 23, 2024
@ArneTR
Merge branch 'main' of github.com:green-coding-solutions/green-metric…
ac5d708 
…s-tool

* 'main' of github.com:green-coding-solutions/green-metrics-tool:
  Codespaces merge into main (#993)
  Container energy idle (#992)
@davidkopp
Copy link
Contributor

That's great!

There is one issue: The added parameter VHost_Ratio for the xgboost model does not work:

TypeError: PsuEnergyAcXgboostMachineProvider.__init__() got an unexpected keyword argument 'VHost_Ratio'

@ArneTR
Copy link
Member Author

ArneTR commented Nov 23, 2024

Thanks. I had already addressed that in #994 but not merged. Should be working now.

The outputted energy is also now tailored to the Codespaces VM. Which was not the case before.

@davidkopp
Copy link
Contributor

Perfect. It works now 😀

ArneTR added a commit that referenced this pull request Nov 23, 2024
@ArneTR
Merge branch 'main' into enterprise
b2aa3bf 
* main:
  Vhost ratio for XGBoost provider (#994)
  Codespaces merge into main (#993)
  Container energy idle (#992)
  Monotonic and low value check (#973)
  Phase Stats are now also saved if runs fails (#972)
  RAPL energy filtering moved to provider (#979)
  fixes the GCC warnings (#985)
  Bump psycopg-pool from 3.2.3 to 3.2.4 (#982)
  Bump aiohttp from 3.11.2 to 3.11.4 (#984)
  Fixed SCI link
  Hinting UTC
  Removed duplicate tests and fixed tests
  Bump aiohttp from 3.11.0 to 3.11.2 (#981)
  Added unit test for rescale energy value
  Bump aiohttp from 3.10.10 to 3.11.0 (#980)
  (fix): Repo submission to software/add was failing on non-main branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArneTR @davidkopp @dan-mm