Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow digits in env var keys #541

Merged

Conversation

davidkopp
Copy link
Contributor

Closes #540

@ArneTR
Copy link
Member

ArneTR commented Nov 16, 2023

@dan-mm The test pipeline cannot execute this external PR. Can you check why.

@ArneTR ArneTR mentioned this pull request Nov 18, 2023
@ArneTR
Copy link
Member

ArneTR commented Nov 18, 2023

The test pipeline failed on this one due a configuration error. We fixed it but cannot make the tests run for this PR. (#546)

I created a copy PR with the fix to run the pipelines. Everything successful!

So this will get merged.

ty @davidkopp <3

@ArneTR ArneTR merged commit 5dea7a2 into green-coding-solutions:main Nov 18, 2023
1 check failed
@davidkopp davidkopp deleted the 540-env-vars-allow-digits branch November 18, 2023 10:33
ArneTR added a commit that referenced this pull request Nov 21, 2023
* main:
  New depencies for XGboost added
  add workflow to build codespace container
  Bump scipy from 1.11.3 to 1.11.4 (#548)
  Bump psycopg[binary] from 3.1.12 to 3.1.13 (#549)
  Fomantic update to 2.9.3 (#547)
  Allow digits in env var keys (#541)
  Hardware info root mac (#544)
  Trying if ref works
  Bump pydantic from 2.5.0 to 2.5.1 (#539)
  Adds the citation file (#537)
  HOG returned after mutliple loops
  Info button now works for page 2+ task coalitions
  Bump pydantic from 2.4.2 to 2.5.0 (#538)
  TDP typo
  Bump pandas from 2.1.2 to 2.1.3 (#534)
  Makes the root_hardware_info root writable only
  Hog API Fix for broken payload (#532)
  Adding report url instead of just ID (#531)
  Makes error optional except if there is data we need (#530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow digits in environment variable keys
2 participants