Noise reduced run start #1023
Merged
Noise reduced run start #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
ArneTR
added a commit
that referenced
this pull request
Dec 19, 2024
* main: (46 commits) Updated cloud energy (fix): Unselect button broke repositories view Noise reduced run start (#1023) (improvement): More strict check Added unselect button [skip ci] (#1022) (fix): tests Clickable Comparsion Charts + Display Missing Values (#1017) Bump uvicorn[standard] from 0.32.1 to 0.34.0 (#1019) Bump playwright/python in /docker/auxiliary-containers/gcb_playwright (#1018) Updated EE Adding not implemented error Kill script for GMT must use full commandline when killing reporters +x for tcpdump Tcp dump (#919) Hash must be decoded to understand spaces [skip ci] Allowing Deeplinks to specific phases [skip ci] (#1016) Bump python from 3.13.0-slim-bookworm to 3.13.1-slim-bookworm in /docker (#1015) Bump pydantic from 2.10.2 to 2.10.3 (#1010) Bump fastapi[standard] from 0.115.5 to 0.115.6 (#1011) Bump aiohttp from 3.11.9 to 3.11.10 (#1013) ...
ArneTR
added a commit
that referenced
this pull request
Dec 22, 2024
* main: pytest.skip() [skip ci] Adding saving for image and volume sizes (#1027) Added average function to badges (#1029) Bump psutil from 6.1.0 to 6.1.1 (#1028) Removing href for non actual links [skip ci] (#1026) Badges for CI now include carbon and also Totals (#998) Removes dead link Bump aiohttp from 3.11.10 to 3.11.11 (#1025) Bump pydantic from 2.10.3 to 2.10.4 (#1024) Bump deepdiff from 8.0.1 to 8.1.1 (#1020) Updated cloud energy (fix): Unselect button broke repositories view Noise reduced run start (#1023) (improvement): More strict check Added unselect button [skip ci] (#1022)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some occurences a machine_id = NULL entry could happen if the runner failed with an unexpected git repo.
This PR reworks this functionality by only saving to the DB once the init checks are all done and the machine verified.
Also adding more short circuits to remove noise when run_id not set
Greptile Summary
Reordered database operations in the runner to prevent NULL machine_id entries and reduce log noise by validating machine configuration before creating database entries.
register_machine_id()beforeimport_metric_providers()to validate machine configuration earlyinitialize_run()to execute after all initialization checks are completerun_idis not setupdate_and_insert_specs()functionality intoinitialize_run()run()method to ensure proper machine validation sequence