remove doubled cache instruction #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaml file parsers are marking the cache instruction as doubled - this commit removes the second ocurrance as it is an exact copy of the first one
|
@dan-mm could you please take a look. I think we needed the caching for venv? |
dan-mm
reviewed
Oct 13, 2023
There was a problem hiding this comment.
Aye the second cache path looks like an oversight, thank you for catching it! I tested this out and it looks good to me.
Only question I have is that this also included the addition of an explicit copy of the eco-ci output from the temp directory into the root directory. AFAIK this shouldn't be needed - am I missing something?
| - cp /tmp/eco-ci/output.txt ./eco-ci-output.txt |
There was a problem hiding this comment.
I'm curious why this was added here - was it needed?
|
@ribalba - the caching is still there, what was removed was an unnecessary duplicate |
|
LGTM. Just talked to Didi, was just a visual oversight from him. Can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yaml file parsers are marking the cache instruction as doubled - this commit removes the second ocurrance as it is an exact copy of the first one