replace cnumr references to replace it by generic description #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
utarwyn
approved these changes
Mar 14, 2023
utarwyn
reviewed
Mar 14, 2023
| <description>Les règles s'appuient sur l'édition 3 du livre "Ecoconception Web / Les 115 bonnes pratiques" => | ||
| https://collectif.greenit.fr/ecoconception-web/115-bonnes-pratiques-eco-conception_web.html | ||
| </description> | ||
| <description>Provides rules to reduce the environmental footprint of your programs</description> |
There was a problem hiding this comment.
I think we can do this change for all SonarQube plugins?
There was a problem hiding this comment.
I agree with you, but it seems that this description is used for all plugins excepted javascript plugin that already define a good description :
ecoCode JavaScript Sonar PluginProvides rules to reduce the environmental footprint of your JavaScript programs
Jberque
pushed a commit
to jhertout/ecoCode
that referenced
this pull request
Mar 20, 2023
* main: upgrade INSTALL.md Sonarqube-ecoCode container image (green-code-initiative#72) upgrade message rule in java plugin + unit test files upgrade CHANGELOG improve unit test on java plugin [ISSUE 55] rename eco-conception to eco-design in java plugin [ISSUE 65] add python plugin info [ISSUE 64] rule message correction + tests [ISSUE 64] correction of dependency error [ISSUE 64] refactoring + correction python rules system replace cnumr references to replace it by generic description (green-code-initiative#75) # Conflicts: # python-plugin/src/main/java/fr/greencodeinitiative/python/RulesList.java # python-plugin/src/test/java/fr/greencodeinitiative/python/PythonRuleRepositoryTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.