[ISSUE 40] refacto 'cnumr' to 'greencodeinitiative' #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
dedece35
requested review from
MP-Aubay,
jules-delecour-dav,
glalloue and
jhertout
dedece35
changed the title
|
OK for me. I go through the modification and I do not see any problems. I have not test. I trust you for that ;) |
jhertout
approved these changes
Jan 30, 2023
utarwyn
reviewed
Feb 3, 2023
| @@ -39,14 +39,14 @@ | |||
| public class JavaRulesDefinition implements RulesDefinition { | |||
|
|
|||
| // don't change that because the path is hard coded in CheckVerifier | |||
| private static final String RESOURCE_BASE_PATH = "fr/cnumr/l10n/java/rules/java"; | |||
| private static final String RESOURCE_BASE_PATH = "fr/greencodeinitiative/l10n/java/rules/java"; | |||
|
|
|||
|
|
|||
| // Add the rule keys of the rules which need to be considered as template-rules | |||
| private static final Set<String> RULE_TEMPLATES_KEY = Collections.emptySet(); | |||
| public static final String NAME = "Collectif Conception Numérique Responsable "; | |||
There was a problem hiding this comment.
no, you're right. correction done (and in other files also)
see a5bcad8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modifications
cnumrtogreencodeinitiative:WARNING : a lot of modifications (as mentionned during weekly appointment)
local tests :
ecodeissues appearsto correct issue #40