Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Swift version of EC512 #291

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Added Swift version of EC512 #291

wants to merge 10 commits into from

Conversation

zippy1978
Copy link
Contributor

@zippy1978 zippy1978 commented Apr 29, 2024

A port of EC512 rule.
This rule already exists for Android / Java.

Addresses issue #290

@zippy1978 zippy1978 added the 🗃️ rule rule improvment or rule development or bug label Apr 29, 2024
@zippy1978 zippy1978 self-assigned this Apr 29, 2024
@zippy1978 zippy1978 requested a review from a team April 29, 2024 14:35
Copy link
Member

@dedece35 dedece35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some conflicts to resolve :(

dedece35
dedece35 previously approved these changes May 13, 2024
@zippy1978
Copy link
Contributor Author

@dedece35 conflicts resolved :)

CHANGELOG.md Outdated
@@ -34,6 +34,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added

- Swift rules cleanup and updates (removed duplicated rules, added [EC602])
- [#18](https://github.com/green-code-initiative/ecoCode-csharp/issues/18) [EC81] [C#] Specify struct layout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicates here too

Copy link
Member

@dedece35 dedece35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please correct duplication on CHANGELOG.dm

@zippy1978 zippy1978 requested a review from dedece35 May 30, 2024 11:48
CHANGELOG.md Outdated Show resolved Hide resolved
@zippy1978 zippy1978 requested a review from dedece35 June 3, 2024 07:31
@dedece35
Copy link
Member

dedece35 commented Jun 8, 2024

sorry @zippy1978 ... but new conflicts to resolve, please :p

Copy link

github-actions bot commented Aug 8, 2024

This PR has been automatically marked as stale because it has no activity for 60 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗃️ rule rule improvment or rule development or bug stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants