Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Java 17 for the SonarQube scan #229

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Use Java 17 for the SonarQube scan #229

merged 1 commit into from
Oct 6, 2023

Conversation

utarwyn
Copy link
Member

@utarwyn utarwyn commented Oct 5, 2023 •
edited
Loading

The same should be done for the other plugins 👍
I haven't updated the changelog because it's very technical and brings nothing to the end user.

Check here to see why this PR is needed

@utarwyn utarwyn added the 🏗️ refactoring refactoring for best practices label Oct 5, 2023
@utarwyn utarwyn self-assigned this Oct 5, 2023
@utarwyn utarwyn force-pushed the sonar-scanner-jdk-17 branch 2 times, most recently from 2d66e41 to 3c54004 Compare October 5, 2023 17:42
@utarwyn utarwyn force-pushed the sonar-scanner-jdk-17 branch from 3c54004 to cd0e442 Compare October 5, 2023 17:45
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@utarwyn utarwyn requested a review from dedece35 October 5, 2023 17:48
dedece35
dedece35 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@dedece35 dedece35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @utarwyn,
review ok for me.

could you make the same modifications on other repositories (python, php, ...) ?

@dedece35 dedece35 added the 👀 👀 review done 👀 👀 review done - waiting for changes label Oct 6, 2023
@utarwyn utarwyn merged commit 16d1c90 into main Oct 6, 2023
3 checks passed
@utarwyn utarwyn deleted the sonar-scanner-jdk-17 branch October 6, 2023 19:43
@utarwyn utarwyn removed the 👀 👀 review done 👀 👀 review done - waiting for changes label Oct 6, 2023
@utarwyn utarwyn mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedece35 dedece35 dedece35 approved these changes

Assignees

@utarwyn utarwyn

Labels
🏗️ refactoring refactoring for best practices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utarwyn @dedece35