Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP] [EC2] Avoid Multiple IfElse Statements #200

Merged
merged 22 commits into from
Aug 4, 2023
Merged

[PHP] [EC2] Avoid Multiple IfElse Statements #200

merged 22 commits into from
Aug 4, 2023

Conversation

dedece35
Copy link
Member

@dedece35 dedece35 commented Jun 6, 2023

PR to replace the old one #160 to apply review notes because of inactivity since 1 month

@dedece35 dedece35 added 🗃️ rule rule improvment or rule development or bug php 🏆 challenge2023 🏆 Work done during the ecoCode Challenge 2023 labels Jun 6, 2023
@dedece35 dedece35 self-assigned this Jun 6, 2023
@dedece35 dedece35 linked an issue Jun 6, 2023 that may be closed by this pull request
EC2[PHP]: Multiple if-else statement #121
Closed
@dedece35 dedece35 mentioned this pull request Jun 6, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.5% 86.5% Coverage
0.0% 0.0% Duplication

@dedece35 dedece35 marked this pull request as draft June 12, 2023 21:13
@dedece35 dedece35 marked this pull request as ready for review June 12, 2023 21:25
@dedece35 dedece35 mentioned this pull request Jun 12, 2023
Closed
EOenedis and others added 19 commits July 28, 2023 19:57
@EOenedis @dedece35
EC2-PHP Avoid Multiple IfElse Statements
f3472f6
@dedece35
[ISSUE 121] update CHANGELOG.md, RULES.md, review feedback
790affb
@dedece35
[ISSUE 121] correction of unit tests + code correction StringUtils
96e4aaf
@dedece35
[ISSUE 121] adding other use cases on tests - implementation to complete
22fe99c
@dedece35
refactoring use case multiple-if-else
f06cb88
@dedece35
[ISSUE 121] refactoring use case multiple-if-else - BIS
d342024
@dedece35
[ISSUE 121] refactoring use case multiple-if-else - TER
dc73ed5
@dedece35
[ISSUE 121] refactoring use case multiple-if-else : else + elsif NON …
328a697 
…compliant uses cases OK
@dedece35
[ISSUE 121] refactoring use case multiple-if-else : refacto method na…
d5126aa 
…mes + elsif use case
@dedece35
[ISSUE 121] refactoring use case multiple-if-else : optimization + co…
0caba6a 
…rrection + refactoring
@dedece35
[ISSUE 121] refactoring use case multiple-if-else : cleaning + adding…
0d256a9 
… use cases + small corrections
@dedece35
[ISSUE 121] refactoring use case multiple-if-else : correction JAVA +…
07ff46c 
… correction PHP unit
@dedece35
[ISSUE 121] refactoring use case multiple-if-else : transfo fichier d…
19907d3 
…escr règle HTML en asciidoc (dans nouveau projet)
@dedece35
[ISSUE 121] refactoring use case multiple-if-else : typo CHANGELOG.md
867e9a9
@dedece35
[ISSUE 121] refactoring use case multiple-if-else : typo CHANGELOG.md…
1c7f922 
… BIS
@dedece35
[ISSUE 121] refactoring use case multiple-if-else : best pratice with…
defc0d4 
… ecocode-rules-specifications module
@dedece35
[ISSUE 121] refactoring use case multiple-if-else : update TODOs_DDC.md
f9ffbc6
@dedece35
[ISSUE 121] refactoring use case multiple-if-else : transfo fichier d…
b6505f7 
…escr règle HTML en asciidoc (dans nouveau projet) - typo
@dedece35
[ISSUE 121] refactoring use case multiple-if-else : add comment + ref…
666e791 
…acto input param names
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dedece35 dedece35 merged commit b2d0744 into main Aug 4, 2023
@dedece35 dedece35 deleted the PR_160_recup branch August 4, 2023 08:52
This was referenced Aug 4, 2023
Closed
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dedece35 dedece35

Labels
🗃️ rule rule improvment or rule development or bug 🏆 challenge2023 🏆 Work done during the ecoCode Challenge 2023 php
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EC2[PHP]: Multiple if-else statement
2 participants
@dedece35 @EOenedis