Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade libraries versions for SonarQube 10.0.0 #188

Merged
merged 11 commits into from
Jun 23, 2023
Merged

upgrade libraries versions for SonarQube 10.0.0 #188

merged 11 commits into from
Jun 23, 2023

Conversation

dedece35
Copy link
Member

No description provided.

@dedece35 dedece35 added 🚀 enhancement New feature or request dependencies Pull requests that update a dependency file php java python javascript labels May 13, 2023
@dedece35 dedece35 marked this pull request as draft May 13, 2023 19:59
@dedece35 dedece35 linked an issue May 13, 2023 that may be closed by this pull request
@utarwyn
Copy link
Member

utarwyn commented Jun 1, 2023

@dedece35 What are the next steps before merging this PR?

@dedece35
Copy link
Member Author

dedece35 commented Jun 2, 2023

@utarwyn ... to have time to check all is ok with dependencies upgrades :(

@utarwyn
Copy link
Member

utarwyn commented Jun 5, 2023

JavaScript plugin seems to work fine on my 10.0 SonarQube server with your changes 👍

@utarwyn utarwyn mentioned this pull request Jun 7, 2023
4 tasks
@dedece35 dedece35 marked this pull request as ready for review June 8, 2023 05:24
@dedece35 dedece35 changed the title upgrade to SonarQube 10.0.0 upgrade libraries versions for SonarQube 10.0.0 Jun 8, 2023
@dedece35
Copy link
Member Author

dedece35 commented Jun 8, 2023

Check Java / python / php plugins :

  • ✅ local unit tests JDK17
  • ✅ local unit tests JDK11
  • SonarQube 10.0.0 (docker JDK 17) + console JDK17 + build JARs with JDK 17 + test-projects JDK17
  • SonarQube 10.0.0 (docker JDK 17) + console JDK11 + build JARs with JDK 11 + test-projects JDK11
  • SonarQube 9.9.1 (docker JDK 17) + console JDK17 + build JARs with JDK 17 + test-projects JDK17
  • SonarQube 9.9.1 (docker JDK 17) + console JDK11 + build JARs with JDK 11 + test-projects JDK11
  • SonarQube 9.9.0 (docker JDK 17) + console JDK17 + build JARs with JDK 17 + test-projects JDK17
  • SonarQube 9.9.0 (docker JDK 17) + console JDK11 + build JARs with JDK 11 + test-projects JDK11
  • SonarQube 9.4 (Jdocker DK 17) + console JDK17
    Sonarqube error during starting :
sonar_ecocode       | chown: /opt/sonarqube/extensions/plugins/ecocode-python-plugin-1.2.2-SNAPSHOT.jar: Operation not permitted
sonar_ecocode       | chown: /opt/sonarqube/extensions/plugins/ecocode-javascript-plugin-1.2.2-SNAPSHOT.jar: Operation not permitted
sonar_ecocode       | chown: /opt/sonarqube/extensions/plugins/ecocode-java-plugin-1.2.2-SNAPSHOT.jar: Operation not permitted
sonar_ecocode       | chown: /opt/sonarqube/extensions/plugins/ecocode-php-plugin-1.2.2-SNAPSHOT.jar: Operation not permitted
  • SonarQube 9.4 (docker JDK 17) + console JDK11
    error : same as above
  • SonarQube 9.8 (docker JDK 17) + console JDK17
    error : same as above
  • SonarQube 9.8 (docker JDK 17) + console JDK11
    error : same as above

@dedece35
Copy link
Member Author

dedece35 commented Jun 8, 2023

Conclusion of tests
for me, my modifications are ok only for Sonarqube >= 9.9 and not versions under.
Thus, if we want to keep modifications (upgrade of libraries), we should release a new major version.
Otherwise, I can investigate more to detect which library is the root cause, but we won't upgrade this library in the future until we accept this incompatibility upgrade.
What do you thin about it, @glalloue, @utarwyn, @jycr, @MP-Aubay, @jhertout, @olegoaer, @mdubois81 ?

@utarwyn
Copy link
Member

utarwyn commented Jun 8, 2023

According to the SonarQube website, the latest LTS available is 9.9, and they strongly encourage users to upgrade to the latest available version, so we might decide to set this version as the minimum. BUT as a majority of our users are companies, it makes sense not to rush updates if maintenance on our side isn't too complex.

I built the plugins based on your branch and put them in my SonarQube 9.8 server (without Docker — sorry I don't have SonarQube 9.4 anymore), and the plugins load and work fine ✅.

image

➡️ @dedece35 Maybe an error with your Docker installation ? It seems to be a file permission issue.

Just for information, an LTS is generally supported for 18 months. See more here: https://endoflife.date/sonar

@dedece35
Copy link
Member Author

@utarwyn thank you for feedback ...
could you test Java plugin on your SonarQube 9.8, please ? (to confirm there is a problem with my docker installation)

@dedece35 dedece35 requested a review from utarwyn June 12, 2023 21:13
@utarwyn
Copy link
Member

utarwyn commented Jun 14, 2023

@dedece35 Java plugin works well on my SonarQube 9.8 and rules are displayed correctly when I analyze Java test project

image

@dedece35
Copy link
Member Author

@utarwyn thank you for tests ! I found the problem.
I use Rancher Desktop to manage docker locally ...
I've just tested with Docker Desktop and all is OK with 9.4 et 9.8 and still not with Rancher Desktop :(
Thanks again !

pom.xml Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@dedece35 dedece35 merged commit aacaeba into main Jun 23, 2023
@dedece35 dedece35 deleted the ISSUE_187 branch June 23, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java php python 🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade librairies to SonarQube 10.0.0
2 participants