Refactors pom.xml files to group all dependency and plugin versions i…

…n one place to make deprecation management easier
green-code-initiative · Oct 18, 2024 · 49b8fcb · 49b8fcb
1 parent 9bb275d
commit 49b8fcb
Show file tree

Hide file tree

Showing 2 changed files with 54 additions and 24 deletions.
diff --git a/ecocode-rules-specifications/pom.xml b/ecocode-rules-specifications/pom.xml
@@ -26,7 +26,6 @@
 				-->
 				<groupId>org.asciidoctor</groupId>
 				<artifactId>asciidoctor-maven-plugin</artifactId>
-				<version>3.0.0</version>
 				<executions>
 					<execution>
 						<id>convert-to-html</id>
@@ -60,7 +59,6 @@
 				-->
 				<groupId>com.github.johnpoth</groupId>
 				<artifactId>jshell-maven-plugin</artifactId>
-				<version>1.4</version>
 				<executions>
 					<execution>
 						<id>prepare-rules-resources</id>
@@ -79,21 +77,6 @@
 						</configuration>
 					</execution>
 				</executions>
-
-				<dependencies>
-					<dependency>
-						<groupId>jakarta.json</groupId>
-						<artifactId>jakarta.json-api</artifactId>
-						<version>2.1.2</version>
-					</dependency>
-
-					<dependency>
-						<groupId>org.glassfish</groupId>
-						<artifactId>jakarta.json</artifactId>
-						<version>2.0.1</version>
-						<classifier>module</classifier>
-					</dependency>
-				</dependencies>
 			</plugin>
 			<plugin><!--
 					This module produce one artifact by language (with corresponding classifier)
@@ -108,7 +91,6 @@
 				-->
 				<groupId>org.apache.maven.plugins</groupId>
 				<artifactId>maven-assembly-plugin</artifactId>
-				<version>3.6.0</version>
 				<executions>
 					<execution>
 						<id>assembly-java</id>

diff --git a/pom.xml b/pom.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
 
     <groupId>io.ecocode</groupId>
@@ -116,11 +115,62 @@
     </properties>
 
     <build>
+        <pluginManagement>
+            <plugins>
+                <plugin>
+                    <groupId>me.qoomon</groupId>
+                    <artifactId>maven-git-versioning-extension</artifactId>
+                    <version>9.6.5</version>
+                </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-enforcer-plugin</artifactId>
+                    <version>3.5.0</version>
+                </plugin>
+                <plugin>
+                    <groupId>org.sonatype.plugins</groupId>
+                    <artifactId>nexus-staging-maven-plugin</artifactId>
+                    <version>1.6.13</version>
+                </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-gpg-plugin</artifactId>
+                    <version>3.1.0</version>
+                </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-assembly-plugin</artifactId>
+                    <version>3.6.0</version>
+                </plugin>
+                <plugin>
+                    <groupId>com.github.johnpoth</groupId>
+                    <artifactId>jshell-maven-plugin</artifactId>
+                    <version>1.4</version>
+                    <dependencies>
+                        <dependency>
+                            <groupId>jakarta.json</groupId>
+                            <artifactId>jakarta.json-api</artifactId>
+                            <version>2.1.2</version>
+                        </dependency>
+                        <dependency>
+                            <groupId>org.glassfish</groupId>
+                            <artifactId>jakarta.json</artifactId>
+                            <version>2.0.1</version>
+                            <classifier>module</classifier>
+                        </dependency>
+                    </dependencies>
+                </plugin>
+                <plugin>
+                    <groupId>org.asciidoctor</groupId>
+                    <artifactId>asciidoctor-maven-plugin</artifactId>
+                    <version>3.0.0</version>
+                </plugin>
+            </plugins>
+        </pluginManagement>
         <plugins>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-enforcer-plugin</artifactId>
-                <version>3.5.0</version>
                 <executions>
                     <execution>
                         <id>enforce-maven</id>
@@ -131,7 +181,7 @@
                             <rules>
                                 <requireMavenVersion>
                                     <!-- Do not specify version upper maven wrapper (cf. ./.mvn/wrapper/maven-wrapper.properties#line=19 -->
-                                    <version>3.9</version>
+                                    <version>3.8.5</version>
                                 </requireMavenVersion>
                             </rules>
                         </configuration>
@@ -197,7 +247,6 @@
                         -->
                         <groupId>org.sonatype.plugins</groupId>
                         <artifactId>nexus-staging-maven-plugin</artifactId>
-                        <version>1.6.13</version>
                         <extensions>true</extensions>
                         <configuration>
                             <serverId>ossrh</serverId>
@@ -216,7 +265,6 @@
                         -->
                         <groupId>org.apache.maven.plugins</groupId>
                         <artifactId>maven-gpg-plugin</artifactId>
-                        <version>3.1.0</version>
                         <executions>
                             <execution>
                                 <id>sign-artifacts</id>