Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE 17] correction EC34 deprecation rule + CHANGELOG.md update #18

Merged
merged 1 commit into from
Jan 12, 2024
Merged

[ISSUE 17] correction EC34 deprecation rule + CHANGELOG.md update #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- [#17](https://github.com/green-code-initiative/ecoCode-php/issues/17) Correction of error with deprecated EC34 rule
- Update ecocode-rules-specifications to 1.4.7

### Deleted

## [1.4.1] - 2024-01-06
Expand All @@ -36,6 +39,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [#121](https://github.com/green-code-initiative/ecoCode/issues/121) new PHP rule : Multiple if-else statement + refactoring implementation
- [#205](https://github.com/green-code-initiative/ecoCode/issues/205) compatibility with SonarQube 10.1

[unreleased]: https://github.com/green-code-initiative/ecoCode-php/compare/v1.4.1...HEAD
[1.4.1]: https://github.com/green-code-initiative/ecoCode-php/compare/v1.4.0...1.4.1
[1.4.0]: https://github.com/green-code-initiative/ecoCode-php/compare/v0.0.0...1.4.0
## Comparison list

[unreleased](https://github.com/green-code-initiative/ecoCode-php/compare/1.4.1...HEAD)
[1.4.1](https://github.com/green-code-initiative/ecoCode-php/compare/1.4.0...1.4.1)
[1.4.0](https://github.com/green-code-initiative/ecoCode-php/releases/tag/1.4.0)
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
<sonar-packaging.version>1.23.0.740</sonar-packaging.version>

<!-- temporary version waiting for real automatic release in ecocode repository -->
<ecocode-rules-specifications.version>1.4.6</ecocode-rules-specifications.version>
<ecocode-rules-specifications.version>1.4.7</ecocode-rules-specifications.version>

<maven-shade.version>3.5.0</maven-shade.version>

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/fr/greencodeinitiative/php/checks/AvoidTryCatchWithFileOpenedCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

@Rule(key = "EC35")
@DeprecatedRuleKey(repositoryKey = "gci-php", ruleKey = "S34")
@DeprecatedRuleKey(repositoryKey = "gci-php", ruleKey = "EC34")
@DeprecatedRuleKey(ruleKey = "EC34")

public class AvoidTryCatchWithFileOpenedCheck extends PHPSubscriptionCheck {

Expand Down