Fix execution of unit tests with Maven #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utarwyn
added
🏗️ refactoring
dedece35
requested changes
Dec 10, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
dedece35
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #10 and #12, there is an issue with the coverage of this plugin. In fact, the problem is that some tests aren't run via Maven: they haven't been migrated to JUnit 5 (Jupiter). What's surprising is that Intellij doesn't complain about it, so it wasn't easy to spot. So, what I have done in this PR:
org.junit.jupiter.api.Test(JUnit 5) instead oforg.junit.test(JUnit 4) in test filesTests are OK on my local SonarQube.
Resolves #12