Merge pull request #18 from green-code-initiative/ISSUE_17

[ISSUE 17] correction EC34 deprecation rule + CHANGELOG.md update
green-code-initiative · Jan 12, 2024 · f3a5a97 · f3a5a97
2 parents 2112667 + a6dee13
commit f3a5a97
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- [#17](https://github.com/green-code-initiative/ecoCode-php/issues/17) Correction of error with deprecated EC34 rule
+- Update ecocode-rules-specifications to 1.4.7
+
 ### Deleted
 
 ## [1.4.1] - 2024-01-06
@@ -36,6 +39,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - [#121](https://github.com/green-code-initiative/ecoCode/issues/121) new PHP rule : Multiple if-else statement + refactoring implementation
 - [#205](https://github.com/green-code-initiative/ecoCode/issues/205) compatibility with SonarQube 10.1
 
-[unreleased]: https://github.com/green-code-initiative/ecoCode-php/compare/v1.4.1...HEAD
-[1.4.1]: https://github.com/green-code-initiative/ecoCode-php/compare/v1.4.0...1.4.1
-[1.4.0]: https://github.com/green-code-initiative/ecoCode-php/compare/v0.0.0...1.4.0
+## Comparison list
+
+[unreleased](https://github.com/green-code-initiative/ecoCode-php/compare/1.4.1...HEAD)
+[1.4.1](https://github.com/green-code-initiative/ecoCode-php/compare/1.4.0...1.4.1)
+[1.4.0](https://github.com/green-code-initiative/ecoCode-php/releases/tag/1.4.0)
diff --git a/pom.xml b/pom.xml
@@ -61,7 +61,7 @@
         <sonar-packaging.version>1.23.0.740</sonar-packaging.version>
 
         <!-- temporary version waiting for real automatic release in ecocode repository -->
-        <ecocode-rules-specifications.version>1.4.6</ecocode-rules-specifications.version>
+        <ecocode-rules-specifications.version>1.4.7</ecocode-rules-specifications.version>
 
         <maven-shade.version>3.5.0</maven-shade.version>
 

diff --git a/src/main/java/fr/greencodeinitiative/php/checks/AvoidTryCatchWithFileOpenedCheck.java b/src/main/java/fr/greencodeinitiative/php/checks/AvoidTryCatchWithFileOpenedCheck.java
@@ -33,7 +33,7 @@
 
 @Rule(key = "EC35")
 @DeprecatedRuleKey(repositoryKey = "gci-php", ruleKey = "S34")
-@DeprecatedRuleKey(repositoryKey = "gci-php", ruleKey = "EC34")
+@DeprecatedRuleKey(ruleKey = "EC34")
 
 public class AvoidTryCatchWithFileOpenedCheck extends PHPSubscriptionCheck {