Use same mechanism to manage/load check rules #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zippy1978, |
dedece35
requested changes
Dec 11, 2023
There was a problem hiding this comment.
Hi @zippy1978,
there is a lot of modification and I saw that core system is upgraded.
If you tested this PR with your real test project and it was ok, thus I will approve the PR (after checking my review comments :p )
|
@dedece35 I confirm I did test this PR on the test project |
|
Kudos, SonarCloud Quality Gate passed! |
dedece35
approved these changes
Dec 11, 2023
|
Hi @zippy1978, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a reworked version of this initial PR: #16
It fixes #15