Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs before release #263

Merged
merged 5 commits into from
Mar 23, 2021
Merged

Fix bugs before release #263

merged 5 commits into from
Mar 23, 2021

Conversation

MaGering
Copy link
Collaborator

@MaGering MaGering commented Mar 23, 2021

Fix #264
With this PR bugs are fixed before the release of pvcompare.

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code
  • Update the CHANGELOG.md (let's start this after the first release)
  • Apply black (black . --exclude docs/)
  • Check if full simulation tests pass locally (EXECUTE_TESTS_ON=master pytest)
    ---> passes at first run
    ===== 75 passed, 67 warnings in 125.44s (0:02:05) ======

Please mark above checkboxes as following:

  • Open
  • Done

❌ Check not applicable to this PR

For more information on how to contribute check the CONTRIBUTING.md.

@MaGering MaGering changed the title Fix fixcost.csv in data_test_main Fix bugs before release Mar 23, 2021
@MaGering MaGering requested a review from SabineHaas March 23, 2021 07:51
@SabineHaas
Copy link
Collaborator

@MaGering I think #264 should be fixed before the release

@MaGering
Copy link
Collaborator Author

@MaGering I think #264 should be fixed before the release

I fixed it with commit 15da7db.

@SabineHaas SabineHaas merged commit 0d045c4 into dev Mar 23, 2021
@SabineHaas SabineHaas deleted the fix/release_bugs branch March 23, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Tests fail locally at second run
2 participants