Upgrade AWS SDK #19
Merged
Upgrade AWS SDK #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have been putting |
|
while we are here, might as well add a composer cache (and --prefer-dist) in there too: https://github.com/graze/skeleton-project/blob/master/.travis.yml the prefer-lowest stuff can be ignored i recon |
biggianteye
commented
Aug 22, 2017
| $formatted = [ | ||
| 'foo' => ['N' => '1'], | ||
| 'bar' => ['N' => '2'] | ||
| ]; |
There was a problem hiding this comment.
The changes in this file are because DynamoDbHandler from monolog does different things based on whether the SDK version is 2 or 3.
https://github.com/Seldaek/monolog/blob/master/src/Monolog/Handler/DynamoDbHandler.php#L77
|
@h-bragg At the moment I'm doing the bare minimum to get this in shape for my other work. I'll do the remaining work to bring it into sync with other projects in a different PR. |
|
Fair snuff. |
h-bragg
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the AWS SDK from 2.x to 3.x. I need this upgrade as it is blocking some work elsewhere.
If we want still want to support 2.x, we can branch off version 1.6 which will be the last version that will support the 2.x SDK.
I don't know much about this project so I'm hoping that either @john-n-smith or @h-bragg can point out any obvious flaws in what I've done.