-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MATOM/MCORE2 lines in lite patch #105
Comments
Also, the full patch should remove the original lines so that it doesn't produce two PS: And ditto for the rustflags. |
Also, |
Also, the |
Hallo Jan. Let me take your suggestions one-by-one for follow-up.
Since these are valid uarches, why do you suggest removing them?
Which original lines are you referencing?
It is used when the user compiles with the
My understanding about the entries in |
Because the patch leaves the original lines in place, creating two cflags-$(CONFIG_MCORE2) += -march=core2
cflags-$(CONFIG_MATOM) += -march=atom
[…]
+ cflags-$(CONFIG_MATOM) += -march=bonnell
+ cflags-$(CONFIG_MCORE2) += -march=core2 And the lite patch, unlike the full one, does not have the
The full patch has the same problem: cflags-$(CONFIG_MCORE2) += -march=core2
cflags-$(CONFIG_MATOM) += -march=atom
[…]
+ cflags-$(CONFIG_MATOM) += -march=bonnell
+ cflags-$(CONFIG_MCORE2) += -march=core2
[…]
rustflags-$(CONFIG_MCORE2) += -Ctarget-cpu=core2
rustflags-$(CONFIG_MATOM) += -Ctarget-cpu=atom
[…]
+ rustflags-$(CONFIG_MATOM) += -Ctarget-cpu=bonnell
+ rustflags-$(CONFIG_MCORE2) += -Ctarget-cpu=core2 Here, the original lines should be removed.
What do you mean?
Fair enough. |
I see now, thank you for the suggestions. Implemented in latest commit. |
These lines should probably be removed:
The text was updated successfully, but these errors were encountered: