forked from Expensify/App
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Even with expensify #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-migration/ReportUtils-lib
…ture/30283-referral-button-share-code
…ture/31218-limit-tags
# Conflicts: # src/components/AutoCompleteSuggestions/BaseAutoCompleteSuggestions.tsx
…ture/31218-limit-tags
…04-run-workflow-tests-on-pr [13604] Run GHA workflow tests on each PR
…dology-questions [Form Provider Refactor] IdologyQuestions
…ank-account-plaid-step [Form Provider Refactor] BankAccountPlaidStep
…n-initial-map-based-on-user-location
`SignInPage` always dark mode
Fix: Extra padding between the header and address field in waypoint editor
Update Pay-Bills.md
fix:31760 recently used tags issue
Limit tag list to 500 items
Display format phone number in suggestion list
…taType Update transaction data type
Add files via upload
Prevent disable cursor when on pressing
Mention search with last name
*Total -- 2,836.91kb -> 2,372.38kb (16.37%) /assets/images/empty-state_background-fade-light.png -- 467.35kb -> 289.72kb (38.01%) /assets/images/empty-state_background-fade-dark.png -- 170.34kb -> 126.27kb (25.87%) /docs/assets/images/Cancel Reimbursement.png -- 213.43kb -> 184.18kb (13.71%) /docs/assets/images/CompanyCards_Unassign.png -- 274.21kb -> 239.07kb (12.81%) /docs/assets/images/CompanyCards_EmailAssign.png -- 292.28kb -> 256.21kb (12.34%) /docs/assets/images/CompanyCards_Assign.png -- 197.55kb -> 173.37kb (12.24%) /docs/assets/images/Reimbursing Reports Dropdown.png -- 174.68kb -> 154.46kb (11.58%) /docs/assets/images/Reimbursing Default.png -- 405.15kb -> 366.14kb (9.63%) /docs/assets/images/Reimbursing Manual.png -- 314.26kb -> 284.28kb (9.54%) /docs/assets/images/Reimbursing Manual Warning.png -- 327.65kb -> 298.67kb (8.84%) Signed-off-by: ImgBotApp <[email protected]>
[ImgBot] Optimize images
revert ref forwarding logic in CheckboxWithLabel
…ment-context [TS Migration] Update EnvironmentContext default value
Update Introducing-Expensify-Chat.md
[TS Migration] Migrate PlaidLink directory to TypeScript
Fix warnings on Settings and Workspace page
fix type for activate card flow
…rmatted-correctly Fix: An extra space in request money promote referral page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop