forked from Expensify/App
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Even with main #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump expensify-common to not allow starting and ending hyphen in local-style urls
…ions/required-confirmation-list
[NoQA] Use specific commit for the setup osbotify action
…s-migration/Button/component
[No QA] Inherit secrets to createChecklist job
…ture/29582-pin-workspace-chat
[NoQA] Fix the path to the action
…Script [TS Migration] remove KeyboardSpacer directory
…ViewToTypeScript [TS Migration] Migrate ReportHeaderSkeletonView.js to TypeScript
…ript [No QA] [TS Migration] migrate AnimatedStep directory's files to TypeScript
…-card-button-and-necessary-routes feat(expensify-card): add get physical card button and routes
[CP Staging] Prevent infinite spinner in transition page
Pin workspace chats upon creation
fix: 30252 Animation is not visible on desktop but visible on Mobile in sign in Modal
[CP Stag] Navigate user to BBA flow
Approving-Reports.md
Remove released betas
…est-workflow [NoQA] change ressure perf test workflow
[NoQA] fix(dev): e2e tests broken
…assure-perf-test-workflow Revert "[NoQA] change ressure perf test workflow"
…tests [NoQA] enable perf tests for ReportScreen
…alue [CP Staging] fix: add missing default value
fix: Attachments reopen on multiple 'esc' click and hang on browser's navigation back
…FullscreenLoading [TS migration] Migrate 'withPolicyAndFullscreenLoading.js' HOC to TypeScript
[CP Stag] Revert "Fix 29806: code paste bug on private note"
…ports [CP Staging] Only show the VBBA payment option for expense reports
Allow editing card transactions (not amount)
Revert "fix: fix lhn previews"
…ponent [TS migration] Migrate 'Button' component to TypeScript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop