Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase text-dy for default shop style #767

Merged
merged 1 commit into from
Jul 29, 2014

Conversation

vholten
Copy link
Contributor

@vholten vholten commented Jul 26, 2014

On the talk list, Jóhannes Birgir Jensson pointed out these shops, for which the name is not rendered:

http://www.openstreetmap.org/node/2939951075
http://www.openstreetmap.org/node/2125818740

Increasing text-dy by one pixel allows the name to be rendered.
Before and after:
old, new

See also #762.

@matthijsmelissen
Copy link
Collaborator

Thanks, well-caught!

@matkoniecz
Copy link
Contributor

It really should be possible to somehow automate finding this "text-dy is too small" bugs.

@matthijsmelissen
Copy link
Collaborator

Maybe test against the tallest possible symbol? Perhaps "ÉÉÉÉÉÉ"?

@pnorman
Copy link
Collaborator

pnorman commented Jul 28, 2014

Maybe test against the tallest possible symbol? Perhaps "ÉÉÉÉÉÉ"?

Doesn't work, as you can have the icon fall between the tall points on the É. Also, Tibetan is taller.

@matthijsmelissen
Copy link
Collaborator

Thanks for pointing that out. Any systematic method?

@pnorman
Copy link
Collaborator

pnorman commented Jul 28, 2014

Any systematic method?

There might be a sufficiently high Unicode block character, but I don't know it. The block elements (e.g. █, ▌, ▜, etc) don't have one.

The problem is we want it to overlap the transparent pixels, but not the opaque ones, otherwise a bit of trivial math and examining the MSS would tell us.

gravitystorm added a commit that referenced this pull request Jul 29, 2014
Increase text-dy for default shop style
@gravitystorm gravitystorm merged commit 4c01284 into gravitystorm:master Jul 29, 2014
@vholten vholten deleted the shop_names branch July 30, 2014 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants