Replace road shields with SVGs #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gravitystorm#693 Fixes gravitystorm#680 Fixes gravitystorm#203 Fixes gravitystorm#202 (mostly) Fixes gravitystorm#146 (mostly) Cross-reference gravitystorm#294 mapnik/mapnik#2020 Starts organization for gravitystorm#508 Replace existing PNG road shields with new SVG ones. This allows for easier adjustment of colour and width as well as sharper high-resolution rendering. At the same time, a number of other shield related bugs are fixed. To aid in organization, a new shields directory is created.
|
As those shields are (hopefully) generated with a script, should it be included in this PR? |
Hah. I wish. Given that I need to consider another set of shields for #670, I might write a script. It could take a generic file and transform it with XSLT... or, because it's limited in scope, I could just write a shell script that takes in the appropriate widths, does math, and spits out a svg. |
|
Just to clarify, I don't suggest waiting on a script for merging this - the first thing I would do with the script is re-run it to get (hopefully) identical results to what I have now. |
gravitystorm
added a commit
that referenced
this pull request
Jul 4, 2014
Replace road shields with SVGs
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #693
Fixes #680 (Or good enough for me to stop fiddling with sub-pixel positioning)
Fixes #203
Fixes #202 (mostly)
Fixes #146 (mostly)
Cross-reference #294 mapnik/mapnik#2020
Starts organization for #508
Replacing PNG shields with SVG ones is a first step in improving rendering of shields. It also allows for much easier customization. Unfortunately we have to specify the shield colours in the SVGs, as two colours are used - the shield colour and white. Even if there weren't two used, mapnik can't recolour a SVG in a ShieldSymbolizer.
To determine shield widths for a given number of characters the ref values in the planet were sorted by character and then road length was counted for each combination of characters. This found the most common ref values, which were then selected from for testing.