Do not render building=supermarket special #550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a corresponding change that needs to be made to the normal buildings layer to include supermarkets. I'd probably hold off adjusting the queries, just don't use the stupid pink colour for now. I'm reworking the SQL, it's somewhat confusing. |
|
You're right, I missed a query. Closed for now until this is fixed. |
pnorman
added a commit
to pnorman/openstreetmap-carto
that referenced
this pull request
May 22, 2014
Replace the old buildings SQL and MSS. This involves resulting changes to landcover stylings to handle landcover which was previously in buildings.mss. Stops rendering supermarkets in a crazy pink to fix gravitystorm#520. Superceeds gravitystorm#550. Moves the rendering of train station areas to landcover. Fixes gravitystorm#327. Fixes gravitystorm#389 Removes outline differences based on a distinction that no one fully understands. Superceeds gravitystorm#533. Fixes gravitystorm#68
|
The query is corrected in #560. |
pnorman
added a commit
to pnorman/openstreetmap-carto
that referenced
this pull request
May 25, 2014
Replace the old buildings SQL and MSS. This involves resulting changes to landcover stylings to handle landcover which was previously in buildings.mss. Stops rendering supermarkets in a crazy pink to fix gravitystorm#520. Superceeds gravitystorm#550. Moves the rendering of train station areas to landcover. Fixes gravitystorm#327. Fixes gravitystorm#389 Removes outline differences based on a distinction that no one fully understands. Superceeds gravitystorm#533. Fixes gravitystorm#68
matthijsmelissen
pushed a commit
to matthijsmelissen/openstreetmap-carto
that referenced
this pull request
Oct 1, 2014
Replace the old buildings SQL and MSS. This involves resulting changes to landcover stylings to handle landcover which was previously in buildings.mss. Stops rendering supermarkets in a crazy pink to fix gravitystorm#520. Superceeds gravitystorm#550. Moves the rendering of train station areas to landcover. Fixes gravitystorm#327. Fixes gravitystorm#389 Removes outline differences based on a distinction that no one fully understands. Superceeds gravitystorm#533. Fixes gravitystorm#68
pnorman
added a commit
that referenced
this pull request
Oct 16, 2014
Refactor buildings code Replace the old buildings SQL and MSS. This involves resulting changes to landcover stylings to handle landcover which was previously in buildings.mss. Stops rendering supermarkets in a crazy pink to fix #520. Superceeds #550. Moves the rendering of train station areas to landcover. Fixes #327. Fixes #389 Removes outline differences based on a distinction that no one fully understands. Superceeds #533. Fixes #68 Rebased in 6b2a4de by math1985 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #520.