Add name to beaches #483
Closed
Add name to beaches #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
text-fill could have also been #000 Closes gravitystorm#455
|
Please note that I only tried the colors for the beach, I did not tried with the exact same set of stylesheets. Also, I am not familiar with the text color rules of openstreetmap-carto, so maybe a standard black text is more appropriate here. Your call. |
|
Thank you for your pull request. @gravitystorm What would be your opinion on the text colors? |
|
Most likely will be replaced by #941 |
|
Yes, but thank you anyway @finetjul! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
text-fill could have also been #000
Closes #455