Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit one index statement per line, add -0 option #4622

Merged
merged 6 commits into from
Sep 21, 2022

Conversation

pnorman
Copy link
Collaborator

@pnorman pnorman commented Jul 26, 2022

These options make it easier to create indexes in parallel.

Fixes #4621

@pnorman pnorman force-pushed the one_line_sql branch 4 times, most recently from 0f51b35 to 41171ad Compare July 26, 2022 04:45
@pnorman pnorman marked this pull request as ready for review July 26, 2022 04:46
@pnorman pnorman added the code label Jul 26, 2022
@pnorman pnorman mentioned this pull request Jul 27, 2022
INSTALL.md Show resolved Hide resolved
scripts/indexes.py Outdated Show resolved Hide resolved
@pnorman
Copy link
Collaborator Author

pnorman commented Sep 17, 2022

Rebased because the index and CI files changed meantime

Copy link
Collaborator

@sommerluk sommerluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would just propose these two minor changes.

INSTALL.md Outdated Show resolved Hide resolved
indexes.yml Outdated Show resolved Hide resolved
@pnorman pnorman merged commit 6508b48 into gravitystorm:master Sep 21, 2022
@pnorman pnorman deleted the one_line_sql branch September 21, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit one index statement per line
3 participants