Test MML queries are valid in CI #4614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnorman
force-pushed
the
test_queries
branch
2 times, most recently
from
fb8bbac to
dbc2fac
Compare
This requires importing empty shapefiles with the same layout as the ones downloaded.
pnorman
commented
Aug 8, 2022
| @@ -0,0 +1 @@ | |||
| Thu 01 Jan 1970 12:00:00 AM UTC | |||
There was a problem hiding this comment.
This (and other) files has a different format than external_data.last_modified, causing an issue. TODO: Change these to Thu, 01 Jan 1970 00:00:00 GMT with no newline.
sommerluk
approved these changes
Aug 25, 2022
sommerluk
approved these changes
Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes PRs come in with basic syntax errors in the queries in the MML file.
This could be because someone committed the wrong changes, or, less charitably, because they never tested. In either case, this is something that can be caught by automation.
Because the tables created depend on the shapefile layout, shapefiles with the same layout are required. The ones here were created by ogr2ogr, filtering all the data out so that only the columns remain.