Render building passages as tunnels #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Render building passages as tunnels if they are tagged with covered=yes or tunnel=building_passage. Previously, they were not rendered at all, and the road was just drawn on top of the building in the regular style. This resolves 2825 and 3757 on trac.
gravitystorm
added a commit
that referenced
this pull request
Apr 8, 2014
Render building passages as tunnels
|
How long does it take for the changes to go live on OSM,org? I've got an example which should render below the building according to this proposal, but it does not: |
|
The carto version on the osm server should be upgraded manually by the server admins (normally Tom Hughes). That has not been done yet, perhaps @gravitystorm knows why. |
matthijsmelissen
added a commit
to matthijsmelissen/openstreetmap-carto
that referenced
this pull request
May 16, 2014
Building passages are now correctly rendered as tunnels. This fix makes sure that such tunnels are not being hidden by the non-tunnel rendering, which was rendered in addition to the tunnel rendering. This is a correction of gravitystorm#444.
matthijsmelissen
added a commit
to matthijsmelissen/openstreetmap-carto
that referenced
this pull request
May 22, 2014
Building passages are now correctly rendered as tunnels. This fix makes sure that such tunnels are not being hidden by the non-tunnel rendering, which was rendered in addition to the tunnel rendering. This is a correction of gravitystorm#444.
|
Still no rendering of tunnel=building_passage? :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render building passages as tunnels if they are tagged with
covered=yes or tunnel=building_passage.
Previously, they were not rendered at all, and the road was
just drawn on top of the building in the regular style.
This resolves 2825 and 3757 on trac.