-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rendering for landuse=salt_pond #4059
Conversation
Adds landuse=salt_pond to landcover in water-color, and to landcover overlay for pattern
ocean-color #b5d7e3 is Lch(84,13,227)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a ΔE of 2.9 the two blues are not distinguishable. If the intent is to have blues you can tell the difference between, they need to be farther apart. If the intent is to have them look the same, they should be exactly the same.
It's supposed to be a subtle difference. But since it makes sense in the context of changing the ocean-color too, I have removed that change and just used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have liked to seen more reviews from people in areas where salt ponds are common, but I'm okay with merging this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks fine.
Already with the original design i was a bit worried about the pattern being too strong - and it is even stronger with the darker background color. On the other hand darkening the symbols to weaken the pattern would make it less recognizable because the color association white -> salt would be lost.
I think that the water color should evenually be changed to be the same as intermittent salt water lakes, and that should be a slightly lighter color, so the pattern will not look quite as strong then. |
Fixes #545
Follow-up to #3905
Changes proposed in this pull request:
#b5d7e3
- Lch(84,13,227)Test rendering with links to the example places:
https://www.openstreetmap.org/#map=15/41.5849/9.2909
Salt evaporation pond area in Corsica
Before
After
https://www.openstreetmap.org/#map=14/-34.8186/138.5977
Salt evaporation ponds (salterns) in South Australia
Before
After