Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add z_order tests #4056

Merged
merged 1 commit into from
Mar 7, 2020
Merged

Add z_order tests #4056

merged 1 commit into from
Mar 7, 2020

Conversation

pnorman
Copy link
Collaborator

@pnorman pnorman commented Mar 7, 2020

This recovers some tests from #4052 that are still worth adding.

@pnorman
Add z_order tests
b36ca93 
These tests were from a PR that didn't work out, but are worth adding
by themselves.
@pnorman pnorman mentioned this pull request Mar 7, 2020
Closed
@jeisenbe jeisenbe mentioned this pull request Mar 7, 2020
Closed
jeisenbe
jeisenbe approved these changes Mar 7, 2020
View reviewed changes
Copy link
Collaborator

@jeisenbe jeisenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These make sense: now we are making sure that the z_order is higher when the highway classification is higher.

@pnorman pnorman merged commit 7efc965 into gravitystorm:master Mar 7, 2020
@pnorman pnorman deleted the z_order_tests branch March 7, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeisenbe jeisenbe jeisenbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnorman @jeisenbe