Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MSS files to style directory #4047

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Move MSS files to style directory #4047

merged 1 commit into from
Mar 6, 2020

Conversation

pnorman
Copy link
Collaborator

@pnorman pnorman commented Mar 3, 2020

Fixes #4041

All style PRs will need rebasing with this move.
No rendering changes.

@jeisenbe jeisenbe mentioned this pull request Mar 3, 2020
Closed
@jeisenbe
Copy link
Collaborator

jeisenbe commented Mar 3, 2020 •
edited
Loading

Do we need to change generate_road_colours.py as well?

Line3: # Generates a set of highway colors to be stored in road-colors-generated.mss.

And later in generate_road_colours.py:
print "/* ./scripts/generate_road_colours.py > road-colors-generated.mss */"

Also, should the mention of fonts.mss in INSTALL.md be changed to style/fonts.mss ?

@jeisenbe jeisenbe added the code label Mar 3, 2020
@pnorman pnorman self-assigned this Mar 3, 2020
@pnorman
Copy link
Collaborator Author

pnorman commented Mar 4, 2020

Line3: # Generates a set of highway colors to be stored in road-colors-generated.mss.

I'm keeping this line as-is intentionally, I feel it reads better using just the filename.

@pnorman pnorman removed their assignment Mar 4, 2020
@pnorman pnorman requested a review from jeisenbe March 6, 2020 03:10
jeisenbe
jeisenbe approved these changes Mar 6, 2020
View reviewed changes
Copy link
Collaborator

@jeisenbe jeisenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, test rendering is unchanged. I didn't try running generate_road_colors.py

@pnorman pnorman merged commit 84d3977 into gravitystorm:master Mar 6, 2020
@pnorman pnorman deleted the mss_directory branch March 6, 2020 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeisenbe jeisenbe jeisenbe approved these changes

Assignees
No one assigned
Labels
code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move MSS files to their own directory
2 participants
@pnorman @jeisenbe