Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render parking at z14 and greater #3612

Merged
merged 1 commit into from
Dec 30, 2018

Conversation

jeisenbe
Copy link
Collaborator

@jeisenbe jeisenbe commented Dec 30, 2018

Changes proposed in this pull request:

  • Render parking at z14 and above only
    (No longer render parking lots at z10 to z13)

Explanation:

  • Parking lots currently render as soon as z10, and the icon is rendered as soon as the way_pixels (height x width) is greater than 900 (eg 30 pixels wind and high), without consideration of zoom level
  • However, very few parking lots are large enough to have an icon at z13 (I have yet to find one), and generally only the fill color is visible
  • The fill color for parking is nearly the same as the background land-color, or the color of untagged land, so parking lots are only visible at z13 and lower when they are surrounded by other land uses or natural areas, and they then appear as a "hole" in the landuse or other area.
  • This is a particular problem in the USA, where many town centers have more than 50% of the land covered in parking lots, thus obscuring most of the retail or commercial area.
  • By stopping rendering parking lots at z10 to z13, it will be easier to see the correct outline of retail, commercial and industrial areas at z13, and developed land in general at z12 and below.

Test renderings with links to the example places:

Kahului, Hawaii
https://www.openstreetmap.org/#map=13/20.9042/-156.4423
z12 Before
z12-kahului
After
z12-kahului-no-parking

z13 Before
z13-kahului
After
z13-kahului-no-parking

Double Resolution to show details:
Before z12 - double
z12-kahului-master-2x
After - double
z12-kahului-no-parking-2x

Before z13 - double
z13-kahului-master-2x
After - double
z13-kahului-no-parking-2x

Washington, DC
z12 Before
z12-washington-master
z12 After
washington-z12-no-parking
z13 Before
z13-washington-master
z13 After
z13-washington-no-parking

Newcastle and Newark, Delaware
z12 Before
z12-newark-newcastle-master
After
z12-newark-newcastle-no-parking

z13 Before
z13-newcastle-airport-master
After
z13-newcastle-airport-no-parking

z12 - double resolution
Before
z12-newark-master-2x
After
z12-newar-no-parking-2x

z13 - 4x resolution
Before
z13-newark-master-4x
After
z13-newark-no-parking-4x

Derry, N. Ireland:
https://www.openstreetmap.org/#map=13/54.9936/-7.3074
z12 before
z12-derry-master
z12 after
z12-derry-after

z13 before
z13-derry-master
z13 after
z13-derry-after

z12 double resolution - before
z12-derry-master-2x
after
z12-derry-2x-after

Belfast, N. Ireland:
https://www.openstreetmap.org/#map=13/54.5975/-5.9104
z12 Before
z12-belfast-master
z12 After
z12-belfast-after

z13 Before
z13-belfast-master
z13 After
z13-belfast-after

z12 - at double resolution
z12-belfast-master-2x
After
z12-belfast-after-2x

Copy link
Collaborator

@matthijsmelissen matthijsmelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@matthijsmelissen matthijsmelissen merged commit a242990 into gravitystorm:master Dec 30, 2018
@kocio-pl
Copy link
Collaborator

Thanks, that's small but good improvement.

@jeisenbe jeisenbe deleted the parking-z13 branch December 30, 2018 15:10
@goldfndr
Copy link

I might be way off here, but does this mean they (parking types) can be removed from landcover/features and amenity_points_poly and only checked in amenity_low_priority and amenity_low_priority_poly?

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Dec 31, 2018 via email

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 4, 2019

Related to #2896.

jeisenbe added a commit to jeisenbe/openstreetmap-carto that referenced this pull request Oct 5, 2019
In PR gravitystorm#3612 it was planned to render parking from z14 only, however this was not changed for the text labels, only for the icon.
This commit fixes the parking rendering at z10 to z13, though in practice almost no parking lots are large enough to have been rendered at these levels.
jeisenbe added a commit that referenced this pull request Oct 25, 2019
…nd fix initial zoom level (#3923)

* Move parking back to amenity-points layers

Parking had previously been rendered in both amenity-points and amenity-low-priority.
Recently PR #3874 had consolidated parking rendering in low-priority only, but this leads to problems when there is a building or an address on the same feature
The minzoom for text-low-priority is changed back to z17

* Change parking text intial zoom to z14

In PR #3612 it was planned to render parking from z14 only, however this was not yet changed for the text labels, only for the icon.

* Change way_pixels limit for parking icon and text

Start showing icon at 750 pixels instead of 900, but don't show text label till 3000 way_pixels, as with most other features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants