-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render parking at z14 and greater #3612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks, that's small but good improvement. |
I might be way off here, but does this mean they (parking types) can be removed from landcover/features and amenity_points_poly and only checked in amenity_low_priority and amenity_low_priority_poly? |
Parking is in both the regular .points layer (for polygons larger than 900
way_pixels) and in the amenity_low_priority layer (for smaller areas and
nodes, but only at z17 or z18 and up). These are both for the icons.
The landcover layer is used for the background fill color, which is still
rendered at z14 and higher.
It’s a little confusing.
…On Mon, Dec 31, 2018 at 11:38 AM Richard Finegold ***@***.***> wrote:
I might be way off here, but does this mean they (parking types) can be
removed from landcover/features
<https://github.com/gravitystorm/openstreetmap-carto/blob/master/project.mml#L148>
and amenity_points_poly
<https://github.com/gravitystorm/openstreetmap-carto/blob/master/project.mml#L148>
and only checked in amenity_low_priority and amenity_low_priority_poly?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3612 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshBcJ9OgomwuaaDi-9nO7m5_qmoA_ks5u-XiqgaJpZM4Zk9qt>
.
|
Related to #2896. |
jeisenbe
added a commit
to jeisenbe/openstreetmap-carto
that referenced
this pull request
Oct 5, 2019
In PR gravitystorm#3612 it was planned to render parking from z14 only, however this was not changed for the text labels, only for the icon. This commit fixes the parking rendering at z10 to z13, though in practice almost no parking lots are large enough to have been rendered at these levels.
jeisenbe
added a commit
that referenced
this pull request
Oct 25, 2019
…nd fix initial zoom level (#3923) * Move parking back to amenity-points layers Parking had previously been rendered in both amenity-points and amenity-low-priority. Recently PR #3874 had consolidated parking rendering in low-priority only, but this leads to problems when there is a building or an address on the same feature The minzoom for text-low-priority is changed back to z17 * Change parking text intial zoom to z14 In PR #3612 it was planned to render parking from z14 only, however this was not yet changed for the text labels, only for the icon. * Change way_pixels limit for parking icon and text Start showing icon at 750 pixels instead of 900, but don't show text label till 3000 way_pixels, as with most other features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
(No longer render parking lots at z10 to z13)
Explanation:
Test renderings with links to the example places:
Kahului, Hawaii
https://www.openstreetmap.org/#map=13/20.9042/-156.4423
z12 Before
After
z13 Before
After
Double Resolution to show details:
Before z12 - double
After - double
Before z13 - double
After - double
Washington, DC
z12 Before
z12 After
z13 Before
z13 After
Newcastle and Newark, Delaware
z12 Before
After
z13 Before
After
z12 - double resolution
Before
After
z13 - 4x resolution
Before
After
Derry, N. Ireland:
https://www.openstreetmap.org/#map=13/54.9936/-7.3074
z12 before
z12 after
z13 before
z13 after
z12 double resolution - before
after
Belfast, N. Ireland:
https://www.openstreetmap.org/#map=13/54.5975/-5.9104
z12 Before
z12 After
z13 Before
z13 After
z12 - at double resolution
After