-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons for shop=fabric and carpet #3555
Conversation
I think it was disscussed and there was a reason people went with it over haberdashery, but I cant remember the details. I agree the numbers are low either way. So I'll remove it. @Tomasz-W, do you remember anything about it? |
@Adamant36 No, it was a quite long and complitated discussion. But as these numbers are small, we can left this icon and add it in the future when situation will be clear. |
@Adamant36 Can you test v2 of 'roll + pattern'? I've mirrored pattern part, I think it looks better in this way. https://gist.github.com/Tomasz-W/24baa83bbed6e1b56b6d86c54d56579f |
@Adamant36 Do you plan to test it? |
Yeah sorry. I've been hella busy lately. I was just thinking about it though. So I'll do it sometime this weekend. Thanks for reminding me. |
Great! Please also remember to remove sewing section. |
I will. |
I also don't see the difference, so no problem... Thanks for you both! |
@matkoniecz, were you able to figure the problem out? It ran fine when I tested it. |
Yes, as mentioned it was insufficient checking on my side. |
Thats good. I just thought id double check just in case. |
I'm always testing patches before merging, so at least they should really work and code should compile (but there can be other problems, of course). |
closes #3289 This PR adds icons for shop=fabric, shop=carpet, and shop=sewing. Its a good idea to add these icons because they look cool and other such reasons.
fabric
https://www.openstreetmap.org/#map=19/40.54160/-80.02588 (node)
https://www.openstreetmap.org/#map=19/40.68446/-80.10688 (way)
carpet
https://www.openstreetmap.org/#map=19/40.52959/-80.00775 (node)
https://www.openstreetmap.org/#map=19/40.60540/-80.05051 (way)
sewing
https://www.openstreetmap.org/#map=19/42.25782/-83.73792 (node)
https://www.openstreetmap.org/#map=19/42.28757/-83.83305 (way)