Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some icons #3533

Merged
merged 3 commits into from
Dec 1, 2018
Merged

Update some icons #3533

merged 3 commits into from
Dec 1, 2018

Conversation

Adamant36
Copy link
Contributor

@Adamant36 Adamant36 commented Nov 28, 2018

Closes #3449 - This PR updates some icons to better looking ones. The arts centre icon gets a musical note, the spoon and fork trade places in the restaurant icon, and the storage tank icon gets thinner.

arts centre
https://www.openstreetmap.org/#map=19/41.40658/-75.65854
arts centre

restaurant
https://www.openstreetmap.org/#map=19/41.40792/-75.66059
restaurant

storage tank
https://www.openstreetmap.org/#map=19/41.40650/-75.66848
storage tank

@kocio-pl, do you happen to know why it would reference your PR in the first commit when I wasn't involved in it and it had nothing to do with this PR?

@kocio-pl
Copy link
Collaborator

No, I don't know why.

@Adamant36
Copy link
Contributor Author

Hhhhmmm, weird.

@Adamant36
Copy link
Contributor Author

New slipway icon
https://www.openstreetmap.org/#map=19/41.25098/-75.88442
slipway

@kocio-pl, it should be good to go now.

@Tomasz-W
Copy link

@Adamant36 Another small thing to fix: I just found that leisure=amusement_arcade icon is in generic 'symbols' folder instead of 'leisure' subfolder https://github.com/gravitystorm/openstreetmap-carto/blob/master/symbols/amusement_arcade.svg

@kocio-pl
Copy link
Collaborator

@Tomasz-W Maybe you would like to learn some basics about git? It would allow you to make at least such trivial fixes. When dealing with software projects, some level of technical skills makes people more effective as community members in general. I really recommend this.

@kocio-pl
Copy link
Collaborator

BTW: there are more icons to be moved into categories, like maybe military (small one) or nature (big one).

@Adamant36
Copy link
Contributor Author

@Tomasz-W, I moved it.
(just to show it works)
arcade

I plan to move the other icons at some point soon largely based on the feedback from the other similar PR. That aside, I agree with @kocio-pl that it might be worth your time to learn some basics of the coding and how things work. Then you could test your own icons etc. Its really not that difficult if your only dealing with basic things like icons and if you have any problems its not we can't help you solve them.

@Tomasz-W
Copy link

@Adamant36 Are you willing to include new slipway icon here?

Gist link: https://gist.github.com/Tomasz-W/c453ba8bc0ab15404d40098a947879e2

@Adamant36
Copy link
Contributor Author

@Tomasz-W, its already there. I tested it above. Unless its different somehow, but it looks the same.

@Tomasz-W
Copy link

@Adamant36 Sorry, too many issues in my head, I got lost for a moment 😄

@Adamant36
Copy link
Contributor Author

No worries. Its been really busy around here lately.

@kocio-pl kocio-pl merged commit 0e7ba08 into gravitystorm:master Dec 1, 2018
@kocio-pl
Copy link
Collaborator

kocio-pl commented Dec 1, 2018

Thanks, our icons just got a bit better. I'm glad to see once again how skilled as a designer and open to discussion @Tomasz-W is, big thanks for all your work in this project!

@Adamant36 Adamant36 deleted the icons branch December 2, 2018 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants