-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some icons #3533
Update some icons #3533
Conversation
No, I don't know why. |
Hhhhmmm, weird. |
New slipway icon @kocio-pl, it should be good to go now. |
@Adamant36 Another small thing to fix: I just found that |
@Tomasz-W Maybe you would like to learn some basics about git? It would allow you to make at least such trivial fixes. When dealing with software projects, some level of technical skills makes people more effective as community members in general. I really recommend this. |
BTW: there are more icons to be moved into categories, like maybe military (small one) or nature (big one). |
@Tomasz-W, I moved it. I plan to move the other icons at some point soon largely based on the feedback from the other similar PR. That aside, I agree with @kocio-pl that it might be worth your time to learn some basics of the coding and how things work. Then you could test your own icons etc. Its really not that difficult if your only dealing with basic things like icons and if you have any problems its not we can't help you solve them. |
@Adamant36 Are you willing to include new slipway icon here? Gist link: https://gist.github.com/Tomasz-W/c453ba8bc0ab15404d40098a947879e2 |
@Tomasz-W, its already there. I tested it above. Unless its different somehow, but it looks the same. |
@Adamant36 Sorry, too many issues in my head, I got lost for a moment 😄 |
No worries. Its been really busy around here lately. |
Thanks, our icons just got a bit better. I'm glad to see once again how skilled as a designer and open to discussion @Tomasz-W is, big thanks for all your work in this project! |
Closes #3449 - This PR updates some icons to better looking ones. The arts centre icon gets a musical note, the spoon and fork trade places in the restaurant icon, and the storage tank icon gets thinner.
arts centre
https://www.openstreetmap.org/#map=19/41.40658/-75.65854
restaurant
https://www.openstreetmap.org/#map=19/41.40792/-75.66059
storage tank
https://www.openstreetmap.org/#map=19/41.40650/-75.66848
@kocio-pl, do you happen to know why it would reference your PR in the first commit when I wasn't involved in it and it had nothing to do with this PR?