Render Wind Turbines names, Change icon to gray, Do not render before z19 if location is rooftop

[jeisenbe]

Fixes #2734
Also resolves #1017

Changes proposed in this pull request:

• Start rendering names of wind turbines (power=generator, generator:source=wind)
• Change wind turbine icon color to man-made-gray
• Render wind turbines only at z19 if location=rooftop or =roof
• Remove rendering for deprecated tagging power=generator with power_source=wind

Explanation:
Wind turbine name labels do not currently render, because the names for power=generator are done in landcover style without any text-dy. This PR adds text-dy: 10 for wind turbines, and the names will be rendered the same as other man_made features, starting at z17 (unless location=rooftop or roof)

The icon color is changed to match other man_made features, because it is currently black. This color is otherwise used only for religious feature icons.

Wind turbines on building rooftops are always much smaller than the large stand-alone towers common in rural areas, so they will now be rendered starting at z19. This will prevent them from blocking building names and the icons for amenities or shops in buildings at z17 and z18. The name label will also be rendered only at z19 in this case.

The tag power_source=wind is deprecated, and is now only used 200 times, vs 200,000 times for generator:source=wind, therefore it will be removed from rendering.

Test rendering with links to the example places:

Before
Blackfriars road z18 before
https://www.openstreetmap.org/#map=18/51.504541/-0.10496

Islington Council building
https://www.openstreetmap.org/#map=18/51.54401/-0.10262
z18 before

z19 before

Strata Building
https://www.openstreetmap.org/#map=18/51.492857/-0.0995045
z18 before

z19 before

Prototype named wind turbine, before
https://www.openstreetmap.org/#map=17/53.5056716/8.5790005

Test rendering z19 before

Test z18 before

After
Blackfriars Road, London z18 (*Name added for test) - still renders because no location tag

AD 8-180 Prototype wind turbine, z17

Islington Council building, z18 - turbine hidden

z19 after

Strata building, z18 - hidden

z19 after

Prototype after

Test rendering z19

• Named rooftop wind turbines show with label
  

Test z18
-rooftop wind turbines hidden, but others render with label.
-Power plants and other power generator labels still render properly as a node or polygon

[Adamant36]

Does a "!=" clause not include a "null"? You'd think it would since "nothing" isn't equal to a roof, or if it was blank it just wouldnt use it as a rendering variable. I only ask because im still learning the code and think its interesting. Not because I think your wrong by doing that way or anything.

[Tomasz-W]

I propose to change wind turbines icon with this occasion, current one is not that readable as it could be:

(current one)
(my proposal)

Gist link: https://gist.github.com/Tomasz-W/8fb5974a1acf6f9e55de3b718e3e3596

PS. This PR resolves also #1017 , so you can change opening post text before its ref to "fixes" or "resolves".

[boothym]

Question - what are valid wind turbine names?

Because I've looked at the ones with names in the UK, and seen the following:

• wind farm names
• manufacturer names/codes (which are also tagged under manufacturer/manufacturer:type)
• a reference number (e.g. A142 or 56)
• Wind | Turbine | Remove the catchall from #roads-text-name #1
• Turbine

Also the translated name for "Wind Turbine" i.e. Aerogenerador in Spanish.

Do these really need to be rendered? Or do we need to improve the data?

[Adamant36]

Id say most of those aren't valid names. Id also imagine most wind turbines don't have legitimate names. Its not a problem specific to wind turbines though. For instance there's a bunch of parks named "park" out there. That being said, the best way to improve the data is to render it so people can see that its wrong and fix it. So I think its still worth rendering the names. Even if most of turn out to be junk.

[jeisenbe]

Re: name rendering: power generator names should currently be rendered, but because wind generators have an icon the name rendering is blocked by the icon at the same location. This PR will make wind generator names render as intended, just like they currently do for solar panels, small hydroelectric, and any other type of power generator.

I agree that most individual power generators do not have real names (usually the entire power plant is named, if there is a name), but hopefully the rendering will encourage mappers to remove incorrect names like "wind turbine" from the database.

Icon change proposal: both the old and new icon look fine to me, so I do not have a strong preference either way. I wish the 3 blades on the new icon were arranged evenly around the circle, but I think this was not possible due to the square shape of the canvas?

Test area with current icon z17:

Test with new icon proposal:

London Blackfriars Road rooftop wind turbines current z18 (NOTE: I have added the "name" as "wind turbine"; this is not in the public database, fortunately)

Proposed icon:

German prototype current z17:

Proposed icon:

Dover wind turbine current z15:

Proposed:

[jeisenbe]

Any opinions on the new or old wind turbine icon?

[kocio-pl]

I prefer the new one, since it's more visible that it has 3 symmetric arms, old one is less clear with shape.

[Adamant36]

I say the new one also. I like that it has a thing in the middle of the blades. It looks clearly that way.

[jeisenbe]

OK, I have pushed a commit with the new icon. I believe this is ready to merge

[kocio-pl]

Thanks, it looks OK in general, however symbols/power_wind.svg file should be removed and new icon file has too much rights (755 instead of 644).

There are also few more icons with 755 mode - it'd be good to make some cleaning, but in a separate PR.

[kocio-pl]

Please change file rights too for symbols/generator_wind.svg, since it belongs to this change, unlike other icons.

[jeisenbe]

Ok, I deleted the old svg, changed permissions on my system and pushed changes. How do I check the permissions on GitHub? I don’t see it in the diff

…

On Fri, Nov 23, 2018 at 8:51 AM kocio-pl ***@***.***> wrote: Thanks, it looks OK in general, however symbols/power_wind.svg file should be removed and new icon file has too much rights (755 instead of 644). There are also few more icons with 755 mode - it'd be good to make some cleaning, but in a separate PR. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3515 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AoxshNGr4pHQOJlHUU43DKjIckNq7Y7Tks5uxziUgaJpZM4Ykvt2> .

[kocio-pl]

I don't see them on the GitHub, but I see 755 on my drive and there's really no trace of such change in your last commit: e99743d

[jeisenbe]

Sorry, it looks like I had to change the permissions via the terminal rather than the “Finder” in MacOS. I used $ chmod u-x <file_name> and $ chmod go-w <file_name> and that changes it from 755 to 644, then commuted changes.

…

On Fri, Nov 23, 2018 at 11:25 AM kocio-pl ***@***.***> wrote: I don't see them on the GitHub, but I see 755 on my drive and there's really no trace of such change in your last commit: e99743d <e99743d> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3515 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AoxshLOi-srlRjLXUIyAurEEA4EXfeqhks5ux1yIgaJpZM4Ykvt2> .

[jeisenbe]

I can make a PR to fix permissions on all the other icons, if it is needed On Fri, Nov 23, 2018 at 12:22 PM Joseph Eisenberg < [email protected]> wrote:

…

Sorry, it looks like I had to change the permissions via the terminal rather than the “Finder” in MacOS. I used $ chmod u-x <file_name> and $ chmod go-w <file_name> and that changes it from 755 to 644, then commuted changes. On Fri, Nov 23, 2018 at 11:25 AM kocio-pl ***@***.***> wrote: > I don't see them on the GitHub, but I see 755 on my drive and there's > really no trace of such change in your last commit: e99743d > <e99743d> > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#3515 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AoxshLOi-srlRjLXUIyAurEEA4EXfeqhks5ux1yIgaJpZM4Ykvt2> > . >

[kocio-pl]

I just wanted to ask you about it... 😄

[kocio-pl]

Thanks! It works OK now and I like new icon more.

[jengelh]

Question - what are valid wind turbine names?

Whatever the owner/city administration decided it to be. Generally speaking, the name can be found on the owner's website (if such exists - not always a given), as a label on a transformer substation nearby (most reliable here in GER), or in news media or city council documents. A common name pattern for Germany is "WKA {locality} {number}", or "WKA {number}", implying the locality. If your UK wind turbines are called "Wind Turbine #1", I guess that's that. If it were just "Wind Turbine" though, I would be concerned. Names should have a disambiguating function, and "Wind Turbine" does not do that justice.

Because I've looked at the ones with names in the UK, and seen the following:
* wind farm names
* manufacturer names/codes (which are also tagged under manufacturer/manufacturer:type)
* a reference number (e.g. A142 or 56)
* Wind | Turbine | #1

All are valid (and different things). That "reference number" btw is generally the manufacturer's serial number.

[HolgerJeromin]

A common name pattern for Germany is "WKA {locality} {number}", or "WKA {number}", implying the locality.

I would move this information to ref tag

[jengelh]

A common name pattern for Germany is "WKA {locality} {number}", or "WKA {number}", implying the locality.

I would move this information to ref tag

That would be a strange thing to do, similar to moving "Umspannwerk {locality}" from name to ref.