Reduce noise of swimming pools at low zoom

[jragusa]

Fixes #585

Changes proposed in this pull request:

• Remove outline of swimming pools between z14 and z17
• Lighten colour of outline

Test rendering with links to the example places:
https://www.openstreetmap.org/#map=15/43.7081/7.3168
Before
z15

z17

z19

After
z15

z17

z19

[matthijsmelissen]

Thanks, so much better on z16-!

I'm not sure about toning down the outline so much on z17+, in my mind the outline also serves to distinguish pools from regular ponds. What do you think?

[jeisenbe]

Is there still an outline at z19 in the “after” test? I can’t see it.

…

On Mon, Oct 22, 2018 at 5:22 AM Matthijs Melissen ***@***.***> wrote: Thanks, so much better on z16-! I'm not sure about toning down the outline so much on z17+, in my mind the outline also serves to distinguish pools from regular ponds. What do you think? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3470 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AoxshNcOA7R0SMCsEuj0CJIjh5ThTRNWks5unNeRgaJpZM4XypBo> .

[jeisenbe]

Oh, now I see it when I zoom in to the z19 image. It’s not noticeable on my mobile phone screen at first, but that’s ok. On Mon, Oct 22, 2018 at 7:59 AM Joseph Eisenberg <[email protected]> wrote:

…

Is there still an outline at z19 in the “after” test? I can’t see it. On Mon, Oct 22, 2018 at 5:22 AM Matthijs Melissen < ***@***.***> wrote: > Thanks, so much better on z16-! > > I'm not sure about toning down the outline so much on z17+, in my mind > the outline also serves to distinguish pools from regular ponds. What do > you think? > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#3470 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AoxshNcOA7R0SMCsEuj0CJIjh5ThTRNWks5unNeRgaJpZM4XypBo> > . >

[jragusa]

with outline from z14
z15

z17

[matthijsmelissen]

I think it would be good to keep the outline (perhaps slightly toned down) on the higher zoomlevels.

[Tomasz-W]

@jragusa I think you confused chosen one values. In the ticket we decided on line-color: saturate(darken(@water-color, 20%), 20%); and in this PR it's different (outlines are less visible)

[jragusa]

@Tomasz-W I indeed pushed wrong value for outline. See below same pictures with corrected outline. They are better visible.
z15

z17

[matthijsmelissen]

Thanks!

[kocio-pl]

@matthijsmelissen Did you use "Squash and merge"? I guess this is a way to prevent to see every single commit in the merging history.

[matthijsmelissen]

I didn't - thanks for the pointer.