Render amenity=internet_cafe #3463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update with changes from master in past month
Follows pattern of amenity=bank
Followed pattern of amenity=bank
Added internet_cafe to amenitypoints and project.mss, and added icon to symbol/amenity
Internet cafe icon changed
Merged changes in master to internet-cafe
26 tasks
kocio-pl
reviewed
Oct 20, 2018
amenity-points.mss
Outdated
| @@ -3084,4 +3092,4 @@ | |||
| trunk/marker-height: 6; | |||
| } | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
It looks like you have accidentally removed new line at the end of file, this is technical detail, but please bring it back.
|
Thanks, this PR looks good in general and I will test it soon, just please resolve a tiny code detail. |
|
I added back the final line on amenity-points.mss |
|
Thanks, my check has showed that it works good. Congratulations on you first PR! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3451
Changes proposed in this pull request:
Adds rendering for amenity=internet_cafe on nodes and closed ways ("areas") with an icon based on the '@' symbol in "amenity brown" color. The icon and name label are rendered at z17 and up, similar to other amenities. Thanks @Tomasz-W for the icon.
Test rendering with links to the examples:
z18 Node with amenity=internet_cafe
https://www.openstreetmap.org/node/5130908200
z19 Node with amenity=internet_cafe
z18 Closed way (area) with amenity=internet_cafe
https://www.openstreetmap.org/way/436919789