Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon for information=tactile_model #3437

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Fix icon for information=tactile_model #3437

merged 1 commit into from
Oct 9, 2018

Conversation

jragusa
Copy link
Contributor

@jragusa jragusa commented Oct 7, 2018

Changes proposed in this pull request:
Replace board icon by map icon for information=tactile_model following comment of @Tomasz-W from #3246

Test rendering with links to the example places:
https://www.openstreetmap.org/node/4362875819 (the land of gift shops)

Before
tactile_model_before

After
tactile_model_after

@matthijsmelissen
Copy link
Collaborator

I think this is getting to detailed - and I don't think many people are going to use our icons to look for tacticle maps.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 7, 2018

It's a small fix, but I think it's just closer to the map than board, so I would fix it.

@kocio-pl kocio-pl merged commit 7ce90cb into gravitystorm:master Oct 9, 2018
@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 9, 2018

Thanks for fixing this detail! Tested and it works.

I don't think many people are going to use our icons to look for tacticle maps

Even if this is small issue indeed, I think this might be important difference in how we see the map: I am not looking for things on a static map, rather I look what is there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants