Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for arcades #3375

Merged
merged 7 commits into from
Sep 19, 2018
Merged

Add rendering for arcades #3375

merged 7 commits into from
Sep 19, 2018

Conversation

meased
Copy link
Contributor

@meased meased commented Sep 1, 2018

@polarbearing
Copy link
Contributor

Seems you contradict your last statement in #3371 where you were favouring a mechanical device over a video character?

@meased
Copy link
Contributor Author

meased commented Sep 1, 2018

Seems you contradict your last statement

Not at all. My point was that the icon should indicate that the venue is an arcade, regardless of whether it is mechanical or video. At the moment, the video character seems to be the best option with the best artwork, if a better icon can be made, great!

I did attempt to make a pinball icon. It was awful... You're welcome to take a stab at it.

@Adamant36
Copy link
Contributor

Adamant36 commented Sep 1, 2018

It might be worth letting @Tomasz-W have a stab at it. He could probably come up with something good. If nothing else a front view of a generic arcade cabinet or something. There's some examples on Noun Project. Along with ones for pinball machines. As it is, this looks to out of place/loud. It doesn't work to have such an abstract icon mixed in with real world ones like that, in my opinion.

@meased
Copy link
Contributor Author

meased commented Sep 2, 2018

Here was my scratch:
arcade_scratch

@Tomasz-W
Copy link

Tomasz-W commented Sep 2, 2018

My icon proposals:

  1. leisure amusement_arcade
  2. leisure amusement_arcade

Gist link: https://gist.github.com/Tomasz-W/6715fe9f45db8b21dcf560b8f4035a35

@Tomasz-W Tomasz-W mentioned this pull request Sep 3, 2018
26 tasks
@meased
Copy link
Contributor Author

meased commented Sep 7, 2018

Updated to the pinball icon as it seems to be well received and was my next favorite.

fl_18_v2
fl_17_v2
qw_18_v2
qw_19_v2
db_18_v2

@polarbearing
Copy link
Contributor

Excellent :-)

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 8, 2018

I have a hard time recognizing it, looks to me like kind of tennis maybe.

@dieterdreist
Copy link

dieterdreist commented Sep 8, 2018 via email

@polarbearing
Copy link
Contributor

Well then, pinball is kind of tennis ;-)

Maybe we put the ball a bit further right, so it is on the far side of the pivot.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 8, 2018

For me it's lack of symmetry. Maybe pinball table shape would be more recognizable.

@meased
Copy link
Contributor Author

meased commented Sep 8, 2018

put the ball a bit further right

It's all the way to the right.

Maybe pinball table shape would be more recognizable

14x14 is very small and it seems complexity is sort of what defines a pinball table.

@dieterdreist
Copy link

dieterdreist commented Sep 8, 2018 via email

@Tomasz-W
Copy link

Tomasz-W commented Sep 9, 2018

Pinball table icon:

leisure amusement_arcade 3

I'm satysfied with pinball arm icon, for me it's recognizable.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 9, 2018

This looks rather like a furniture for me, I meant something like view from the top:

https://cdn.shopify.com/s/files/1/0696/2897/products/Baseball_Pinball_3.png?v=1494963466

@Tomasz-W
Copy link

Tomasz-W commented Sep 9, 2018

something like view from the top

it's too complicated to make an 14x14 icon presenting it

@polarbearing
Copy link
Contributor

It's all the way to the right.

Indeed, I see when putting a ruler on the right side. Interesting optical illusion. The ball looks a bit more centred without the ruler.

Still find the flipper/ball icon more recognisable than the table side.
I had experimented myself with a top view of the table earlier. Having a frame already takes so much pixelspace that it is hard to have anything recognisable within.

@kocio-pl
Copy link
Collaborator

Thanks for checking it, @polarbearing.

I would go with original "monster" or spaceship icon. They are much more readable than flipper/ball icon and without the knowledge about arcade games there are no shapes that could work.

@polarbearing
Copy link
Contributor

Still like the flipper more. The monster is highly specific to a particular video game, and it gives the venue a prominence it does not deserve. . But I fear the laymen test would fail for both.

@meased
Copy link
Contributor Author

meased commented Sep 11, 2018

I'll try a test with a spaceship later, see how that goes.

@meased
Copy link
Contributor Author

meased commented Sep 14, 2018

Trying a spaceship icon:

arcade_ship_fl17
arcade_ship_fl18
arcade_ship_qw18
arcade_ship_qw19

@Tomasz-W
Copy link

I think it looks like some kind of tower. As some people wenen't satisfied with pinball design, I would go with "space invider" design or add leirure-green generic dot for this feature (which may be the best solution, because we still aren't sure if electronic icon is a good for something which could be non-electronic)

@Adamant36
Copy link
Contributor

Adamant36 commented Sep 14, 2018

I vote for green dot. A lot of arcades aren't exclusively for arcade or pinball machines. Plus, most of them have the name "arcade" in them anyway. Maybe leaving them as a green dot would spur people on to add the names to more of them if nothing else. Also, some arcades are inside other places. So a dot makes sense in those cases as well.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Sep 15, 2018

I think it looks like some kind of tower.

Yes, more or less.

As some people wenen't satisfied with pinball design, I would go with "space invider" design or add leirure-green generic dot for this feature (which may be the best solution, because we still aren't sure if electronic icon is a good for something which could be non-electronic)

I would still go with invader.

Dots are poor way of communicating with a map user - if she's not able to recognize arcade, that's the same as with dots of course, but if she can, it adds some information about the object. We use dots only as a placeholder or to deal with clutter (shops) - and this is not this case. I also think green dot is too general, because leisure is much broader category than a shop or an office.

@meased
Copy link
Contributor Author

meased commented Sep 16, 2018

Trying a modification to the invader:

  • Lower portion is now reminiscent of a pacman ghost (combining pacman and space invader themes).
  • Height reduced to lower the amount of "ink" used.

fl_newinv_18

@kocio-pl
Copy link
Collaborator

I like this version, especially making it a bit smaller.

@dieterdreist
Copy link

dieterdreist commented Sep 17, 2018 via email

@kocio-pl
Copy link
Collaborator

I guess this is the best we could find and I'd like to test and merge it soon, but there are conflicts to fix after merging #3384.

@meased
Copy link
Contributor Author

meased commented Sep 19, 2018

Updated with master. More testing (same areas as above):

fl17
fl18
fl19

qw_17
qw_18
qw_19

db17
db18
db19

@kocio-pl kocio-pl merged commit e637955 into gravitystorm:master Sep 19, 2018
@kocio-pl
Copy link
Collaborator

Thanks! My testing also shows it's OK.

This one was fun. 😄

@meased meased deleted the arcade branch September 19, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants