-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Indoor rendering #3364
WIP: Indoor rendering #3364
Conversation
As I really would like to have some separate service with indoor rendering, I'm worried this is a bad idea for default style. It's very detailed at the moment, and this feature would complicate orientation in map a lot. I mean it would be very nice to have some separate service with this function for people interested in certain buildings interiors, but I'm worried that for most of users it may be an obstacle. Anyway, I would like to see building:part=* names (#3188), which on the one hand will be useful, and on the other hand they won't clutter the map. |
https://openlevelup.net/?l=0#18/45.52832/-122.66258 Although:
How so? It's high zoom only, in an area that would otherwise be a vast, empty building shape. In areas such as malls and airports, it would actually improve orientation (a lot), and I can't come up with a case where it would hurt.
It has been highly successful in Google Maps. Not that we should copy them, but it shows that the general population is not only okay with it, they love it.
Agreed. I actually see rendering building:part names as dabbling the the dark arts of indoor mapping. I just took it a lot farther. |
@meased I forgot to mention one argument, which actually may be the most important. As I can admit that your test renderings looks quite ok and promising, they are presenting well-mapped interiors. but I remember examples of indoor mapping in my city - building parts was out of building shape, certain rooms wasn't stich to each other, etc, I'm worried how would it look in cases like that. The perfect solution for me would be to show interior rendering after clicking on building shape, but as we don't have vector tiles and clicability, it surely won't happen soon. |
This is definitly something that should motivate us to get to vector tiles faster. :-) |
@Tomasz-W yes, I hand selected areas that look good, and ignored some rather major problems. Poorly mapped areas are going to look bad, and I personally don't think this style should attempt to make them look better, it provides motivation to clean the data. Its been mentioned before, but vector tiles aren't a magic wand that will solve all cartography issues. If we had vector tiles today, a building with only one floor (the most common case) would look and behave identical to the images above, and we can start solving those problems today. Another issue is the competition between indoor rendering and 3D roof rendering, some people will want one, some will want the other. Vector tiles to the rescue, right? But what does that look like? What do you show by default? How many layers are hiding? How do you know they are there? It's an interface nightmare... |
I agree with @Tomasz-W that this style should focus on the flat map. There are other interfaces that address indoor and levels, beside the one mentioned by @meased you might have a look at https://openstationmap.org which is switchable between 3D/2D. |
First of all, thanks @meased for making such research! ❤️ I like very much your analyze. However I don't feel it's good to show indoor on OSM Carto, because adding internal details will clutter map sooner or later. The only thing I think that could be useful is filtering levels other than "0" (including most of the underground objects) - see #1977. |
Thanks again for this idea, however I still think it would add visual clutter in general, so I will close it now without merging. |
First off, this is not a (completely) serious PR. This is just me messing around and I got some cool results that I decided to share.
The first obvious issue with indoor rendering is that there is no way select different floors. I solved this by only displaying the main floor, e.g.
tags->'level' IS NULL OR tags->'level' = '0'
.The results:
https://www.openstreetmap.org/#map=17/45.52838/-122.66303
https://www.openstreetmap.org/#map=18/45.62839/-122.66863
And zoom 20, just for fun.
Lost the link to this one (somewhere in Taiwan):
Here's what I learned:
Pros
Same mall (try to imagine with only POIs from one level):
Cons
0-3
,0;2;3
).level=0
.level
tag as big nasty relations are both hard to map and hard to query.This is a 50% solution. The question I'm trying to push is this: could something like this work as a starting point to build up to a 100% solution, or do we hold out for the 100% solution.