-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kosmtik, db, import Dockerfiles for Ubuntu 18.04 and nodejs 8 #3310
Conversation
@Penegal @jragusa @Adamant36 @james2432 @meased (and anybody else): could you test if this change works for you? I'd like to know that this is safe to merge, since it will directly impact using Docker environment. |
It ran fine for me. |
same for me |
Just to be sure that you didn't end up with the old images - did you make When doing my build of
|
I'm getting the same error as @kocio-pl. |
same |
same here |
@skylerbunny Could you fix this problem and test how it works on your computer? |
My apologies. Changes to the Dockerfile.import file were needed. New squashed commit is ready on this PR. ( Commit is https://github.com/skylerbunny/openstreetmap-carto/commit/c0102d26c1baa573e8d3d879c30e2bb9225f497f ) |
Seems to work now on my end. |
Works good for me now... |
OK, works for me too. Any reasons to not merge it yet? |
I say merge it. It works and it doesnt seem like there is anyone else around to test it more anyway. So why not? |
Thanks, @skylerbunny! Looks like 18.04 has been deployed on OSMF servers (I see new Mapnik rendering, for example label on Victoria lake is no longer out of center or even out of water!), so it's safe to follow them. |
Fixes #3308
Changes proposed in this pull request:
fonts-hanazono
fonts package which was never included in Dockerfile but is mentioned in the install guideTesting performed:
docker-compose up import (against a data.osm.pbf file)
docker-compose up kosmtik