Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kosmtik, db, import Dockerfiles for Ubuntu 18.04 and nodejs 8 #3310

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Update kosmtik, db, import Dockerfiles for Ubuntu 18.04 and nodejs 8 #3310

merged 1 commit into from
Aug 9, 2018

Conversation

skylerbunny
Copy link
Contributor

@skylerbunny skylerbunny commented Jul 19, 2018

Fixes #3308
Changes proposed in this pull request:

  • Postgresql 10 (as is the default is in Ubuntu 18.04, Bionic Beaver)
  • Nodejs 8.x (also its default)
  • Addition of fonts-hanazono fonts package which was never included in Dockerfile but is mentioned in the install guide
  • Sets the prefix of npm installation to /usr, which is what kosmtik expects (Default in Ubuntu 18.04 npm package is /usr/local, which confused its installation scripts). Kosmtik is expected to be node 8 compatible. See kosmtik/kosmtik@aed8789 .

Testing performed:
docker-compose up import (against a data.osm.pbf file)
docker-compose up kosmtik

@skylerbunny skylerbunny reopened this Jul 19, 2018
@kocio-pl
Copy link
Collaborator

@Penegal @jragusa @Adamant36 @james2432 @meased (and anybody else): could you test if this change works for you? I'd like to know that this is safe to merge, since it will directly impact using Docker environment.

@Adamant36
Copy link
Contributor

It ran fine for me.

@james2432
Copy link
Contributor

same for me

@kocio-pl
Copy link
Collaborator

Just to be sure that you didn't end up with the old images - did you make docker-compose down to remove old containers and docker-compose build to create new ones, followed by successful new import and running new containers?

When doing my build of import image I get this error:

Step 3/9 : RUN apt-key adv --keyserver keyserver.ubuntu.com     --recv A438A16C88C6BE41CB1616B8D57F48750AC4F2CB
 ---> Running in 69ca4169fa60
E: gnupg, gnupg2 and gnupg1 do not seem to be installed, but one of them is required for this operation
ERROR: Service 'import' failed to build: The command '/bin/sh -c apt-key adv --keyserver keyserver.ubuntu.com     --recv A438A16C88C6BE41CB1616B8D57F48750AC4F2CB' returned a non-zero code: 255

@meased
Copy link
Contributor

meased commented Jul 24, 2018

I'm getting the same error as @kocio-pl.

@james2432
Copy link
Contributor

same

@Adamant36
Copy link
Contributor

same here

@kocio-pl
Copy link
Collaborator

@skylerbunny Could you fix this problem and test how it works on your computer?

@skylerbunny
Copy link
Contributor Author

My apologies. Changes to the Dockerfile.import file were needed.

New squashed commit is ready on this PR. ( Commit is https://github.com/skylerbunny/openstreetmap-carto/commit/c0102d26c1baa573e8d3d879c30e2bb9225f497f )

@Adamant36
Copy link
Contributor

Seems to work now on my end.

@meased
Copy link
Contributor

meased commented Jul 25, 2018

Works good for me now...

@kocio-pl
Copy link
Collaborator

OK, works for me too. Any reasons to not merge it yet?

@Adamant36
Copy link
Contributor

I say merge it. It works and it doesnt seem like there is anyone else around to test it more anyway. So why not?

@kocio-pl kocio-pl merged commit 733dc71 into gravitystorm:master Aug 9, 2018
@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 9, 2018

Thanks, @skylerbunny!

Looks like 18.04 has been deployed on OSMF servers (I see new Mapnik rendering, for example label on Victoria lake is no longer out of center or even out of water!), so it's safe to follow them.

@skylerbunny skylerbunny deleted the docker-bionic branch August 9, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Dockerfile and Dockerfile.* ubuntu:bionic compatible
5 participants