-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon for shop=ticket #3286
Add icon for shop=ticket #3286
Conversation
Thanks! Could you please show just the area around the object? It's hard for me to find them and it should be easy to make the selection with the Kosmtik export. |
Sure. Its hard for me to find them to. I didn't know you could do it that way. I've been taking screen captures and cropping them. If you could update your list of code needed for icons in issue #3105 for this issue when its merged, along with the one for Guidepost and Map Icons, I would appreciate it. Thanks |
Hmm, the icon looks a little bit "empty". I made inverted versions for compare. @Adamant36 Can you try them? Gist link: https://gist.github.com/Tomasz-W/b18eee2375829d1fa2e97f40fd855968 PS. Don't forget about "magic" words which closes issues automatically: https://help.github.com/articles/closing-issues-using-keywords/ |
It's always better to export images, because for example Chrome has some problems with handling colors. However even when making a screenshot just crop it more accurately and it would be OK. |
I vote for "2" |
Good. Thats the way I was leaning to. I'll update the pr as soon as I get the branch thing resolved. |
Another vote for 2. |
So I was trying to update the ticket.svg file and I screwed up and readded it as an .png. So now there's two of them. Is there a way to delete ticket.png and get the correct ticket file added that's not a total hassle? |
Delete the file |
@kocio-pl It looks like this one is good to go. Id appreciate it if you could merge it before I fix whatever is wrong with interior decoration so I wont risk screwing it up again. Sorry about the problems. Lesson learned on using branches I guess. @sommerluk, thanks for the help. I was kind of freaking out for a minute there that I screwed something up. |
Thanks, works as expected! |
Please remember to add closing statement in the proper way, so it will close corresponding issue automatically: https://help.github.com/articles/closing-issues-using-keywords/ |
This pull request adds an icon for shop=ticket and closes issue #3115
https://www.openstreetmap.org/#map=19/37.73301/-122.50486 (node)
https://www.openstreetmap.org/#map=19/37.76897/-122.47026 (way)