Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for shop=ticket #3286

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Add icon for shop=ticket #3286

merged 1 commit into from
Jul 11, 2018

Conversation

Adamant36
Copy link
Contributor

@Adamant36 Adamant36 commented Jul 3, 2018

This pull request adds an icon for shop=ticket and closes issue #3115
https://www.openstreetmap.org/#map=19/37.73301/-122.50486 (node)
ticket node
https://www.openstreetmap.org/#map=19/37.76897/-122.47026 (way)
ticket way

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 3, 2018

Thanks!

Could you please show just the area around the object? It's hard for me to find them and it should be easy to make the selection with the Kosmtik export.

@Adamant36
Copy link
Contributor Author

Sure. Its hard for me to find them to. I didn't know you could do it that way. I've been taking screen captures and cropping them. If you could update your list of code needed for icons in issue #3105 for this issue when its merged, along with the one for Guidepost and Map Icons, I would appreciate it.

Thanks

@Tomasz-W
Copy link

Tomasz-W commented Jul 3, 2018

Hmm, the icon looks a little bit "empty". I made inverted versions for compare.

  1. shop ticket 2
  2. shop ticket 3

@Adamant36 Can you try them?

Gist link: https://gist.github.com/Tomasz-W/b18eee2375829d1fa2e97f40fd855968

PS. Don't forget about "magic" words which closes issues automatically: https://help.github.com/articles/closing-issues-using-keywords/

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 3, 2018

It's always better to export images, because for example Chrome has some problems with handling colors. However even when making a screenshot just crop it more accurately and it would be OK.

@Adamant36
Copy link
Contributor Author

Adamant36 commented Jul 3, 2018

Ticket 2 (way)
ticket 2 way
Ticket 2 (node)
ticket 2 node
Ticket 3 (way)
ticket 3 way
Ticket 3 (node)
ticket 3 node

@Tomasz-W
Copy link

Tomasz-W commented Jul 4, 2018

I vote for "2"

@Adamant36
Copy link
Contributor Author

Good. Thats the way I was leaning to. I'll update the pr as soon as I get the branch thing resolved.

@lakedistrictOSM
Copy link

Another vote for 2.

@Adamant36
Copy link
Contributor Author

So I was trying to update the ticket.svg file and I screwed up and readded it as an .png. So now there's two of them. Is there a way to delete ticket.png and get the correct ticket file added that's not a total hassle?

@sommerluk
Copy link
Collaborator

Delete the file ticket.png, than do git add ticket.png.

@Adamant36
Copy link
Contributor Author

Adamant36 commented Jul 11, 2018

@kocio-pl It looks like this one is good to go. Id appreciate it if you could merge it before I fix whatever is wrong with interior decoration so I wont risk screwing it up again. Sorry about the problems. Lesson learned on using branches I guess.

@sommerluk, thanks for the help. I was kind of freaking out for a minute there that I screwed something up.

@kocio-pl kocio-pl merged commit b577303 into gravitystorm:master Jul 11, 2018
@kocio-pl
Copy link
Collaborator

Thanks, works as expected!

@kocio-pl
Copy link
Collaborator

Please remember to add closing statement in the proper way, so it will close corresponding issue automatically:

https://help.github.com/articles/closing-issues-using-keywords/

@Adamant36 Adamant36 deleted the icon/ticket branch July 14, 2018 14:06
@jeisenbe jeisenbe added new features Requests to render new features POI labels Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new features Requests to render new features POI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants