Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel align the ford icon #3229

Merged
merged 3 commits into from
May 19, 2018
Merged

Pixel align the ford icon #3229

merged 3 commits into from
May 19, 2018

Conversation

meased
Copy link
Contributor

@meased meased commented May 12, 2018

Fixes #2822

The arrow is a little fatter because arrows need to end on a point to look sharp and therefore need to have an odd height. One water line is removed to reduce the weight a little and to keep the design language the same as waterfall, public_bath, beach_resort, and water_park

Icon before:
ford_before
ford_before_grid

Icon after:
ford_after
ford_after_grid

https://www.openstreetmap.org/#map=16/45.3493/-121.6580
Before:
ford_before_sample

After:
ford_after

@matthijsmelissen
Copy link
Collaborator

matthijsmelissen commented May 12, 2018

Looks good.

The antialiasing at the bottom might look better with the water moved up one pixel?

@kocio-pl
Copy link
Collaborator

I would rather make the waves 1 px higher than move them up, to make them more visible.

@dieterdreist
Copy link

dieterdreist commented May 12, 2018 via email

@imagico
Copy link
Collaborator

imagico commented May 12, 2018

For reference: The original discussion for the current ford icon can be found in #1625.

@meased
Copy link
Contributor Author

meased commented May 12, 2018

The waves are identical to the ones used in the public_bath, beach_resort, and water_park icons (when I did the waterfall icon different waves were used, though I probably shouldn't have). If it is not recognizable here, then I feel the other icons should be updated too (which I'm not opposed to doing).

The waterfall icon starts the waves out of sync, which I think makes it look more natural and less like a triple "M", and obviously if the waves are bigger they will be more recognizable (at the expense of less space to draw in the top part). Here are the thick/thin/tall/short variations with offset waves:
water_options

@kocio-pl
Copy link
Collaborator

4 is the best for me.

@geozeisig
Copy link

Why do you use a loupe? In my eyes, the icon looks amazing good in 1: 1 mode.

@meased
Copy link
Contributor Author

meased commented May 15, 2018

I liked 3 and 4, @kocio-pl liked 4, so unless anyone else weighs in I have updated this PR to use icon 4.

@matthijsmelissen
Copy link
Collaborator

Thanks!

@matthijsmelissen matthijsmelissen merged commit 6684ee0 into gravitystorm:master May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants