Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for zip line #3172

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Add rendering for zip line #3172

merged 1 commit into from
Apr 16, 2018

Conversation

jragusa
Copy link
Contributor

@jragusa jragusa commented Apr 10, 2018

Fixes #3156

Changes proposed in this pull request:
Display aerialway=zip_line as other aerialways (e.g. chair_lift)

Test rendering with links to the example places:
Fantasticable 1 and 2
Before
zipline_before

After
zipline_after

@jragusa jragusa changed the title Add rendering of zip line Add rendering for zip line Apr 10, 2018
@kocio-pl
Copy link
Collaborator

What about name rendering?

@jragusa
Copy link
Contributor Author

jragusa commented Apr 11, 2018

Sorry, I missed that
On a shorter way: https://www.openstreetmap.org/way/389429866
zipline_name

@kocio-pl
Copy link
Collaborator

I was thinking about making rendering a bit different (for example bigger space between markers), but it looks like this kind of rendering is already made different for all lighter aerialways, so it's probably a proper solution.

@kocio-pl kocio-pl merged commit 8de55b0 into gravitystorm:master Apr 16, 2018
@kocio-pl
Copy link
Collaborator

Independent testing of a different place gave the same result - thanks for fixing this issue!

@jragusa jragusa deleted the zipline branch May 7, 2018 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants